Bump sl4j-api to 2.x #3956
Merged
Bump sl4j-api to 2.x #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also switch the optional logback-{core,classic} dependencies to 1.3.x
This was referenced Mar 3, 2023
melissalinkert
approved these changes
Mar 6, 2023
Merged
dgault
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Happy to get all of these included as part of 7.1.0 as long as it is OK for OMERO downstream (ome/omero-blitz#137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussions at #3943 (comment) and ome/bio-formats-examples#102 (comment)
Bio-Formats 6.12.0 included the declaration of logback-core and logback-classic as optional dependencies in agreement with the recommendations of the slf4j framework. As. part of the testing and while trying to upgrade logback to modern versions across the board, it was found that the current version of slf4-api shipped with ome-common & Bio-Formats imposes a constraint on logback. This can be highly dependent of the build system and the way dependencies are resolved but the logback 1.2.9 released Dec 17, 2021 is the last version that uses slf4-api 1.x.
This commit explores bumping the slf4-api version to 2.x. For library usages, this means logback should be upgraded to a compatible version, either 1.3.x (Java 8+) or 1.4.x (Java 11+)
Tentatively assigning to 6.13.0