Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sl4j-api to 2.x #73

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Bump sl4j-api to 2.x #73

merged 5 commits into from
Dec 5, 2023

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Mar 3, 2023

See ome/bioformats#3956

This commit explores upgrading the slf4-api version to 2.x. For concrete implementations, this means logback should be upgraded either to 1.3.x (Java 8+) or 1.4.x (Java 11+)

Also switch the optional logback-{core,classic} dependencies to 1.3.x
@sbesson sbesson marked this pull request as draft March 11, 2023 07:54
@sbesson sbesson changed the title Bump sl4j-api to 2.0.6 Bump sl4j-api to 2.x Mar 14, 2023
@sbesson sbesson marked this pull request as ready for review March 20, 2023 14:42
@sbesson sbesson marked this pull request as draft March 24, 2023 06:27
@sbesson
Copy link
Member Author

sbesson commented Oct 2, 2023

Discussed today at the weekly @ome/formats meeting. Planning to take this PR alongside all accompanying logback 1.2-> 1.3 PR out of draft mode after the release of Bio-Formats 7.0.1. From there, we can assess the impact of the upgrade to slj4-api 2.x/logback 1.3+ across the entire Java stack /cc @jburel

@sbesson sbesson marked this pull request as ready for review November 3, 2023 11:14
@dgault dgault merged commit 33e52e3 into ome:master Dec 5, 2023
9 checks passed
@sbesson sbesson deleted the slf4j-api_2 branch December 5, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants