Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gh-actions] build-package jobs are failing on the ubuntu-22.04 runners #16450

Closed
dmitryax opened this issue Nov 23, 2022 · 12 comments · Fixed by #30202
Closed

[gh-actions] build-package jobs are failing on the ubuntu-22.04 runners #16450

dmitryax opened this issue Nov 23, 2022 · 12 comments · Fixed by #30202
Assignees
@codeboten
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues good first issue Good for newcomers help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium

Comments

@dmitryax
Copy link
Member

dmitryax commented Nov 23, 2022 •
edited
Loading

GitHub actions runner ubuntu-latest tag was recently upgraded from Ubuntu 20.04.5 to Ubuntu 22.04.1.

The build-package job is failing now. We need to investigate and update it to work on the latest Ubuntu version.

Failing job examples:
@dmitryax dmitryax added bug Something isn't working priority:p2 Medium ci-cd CI, CD, testing, build issues help wanted Extra attention is needed labels Nov 23, 2022
@dmitryax dmitryax mentioned this issue Nov 23, 2022
Merged
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jan 23, 2023
@dmitryax dmitryax added good first issue Good for newcomers and removed Stale labels Jan 23, 2023
@jlabatut
Copy link

jlabatut commented Mar 8, 2023

Hi @dmitryax, is this issue still open ? If so, can I be assigned to it ?
(Also, the jobs log examples have expired)

@jlabatut jlabatut mentioned this issue Mar 8, 2023
Closed
@dmitryax
Copy link
Member Author

dmitryax commented Mar 8, 2023

@jlabatut, thanks for offering help!

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label May 8, 2023
@dmitryax dmitryax removed the Stale label May 8, 2023
@codeboten codeboten self-assigned this Jun 28, 2023
codeboten referenced this issue in codeboten/opentelemetry-collector-contrib Jun 28, 2023
[chore] update runner to latest
666b0fb 
Fixes #16450

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten mentioned this issue Jun 28, 2023
Closed
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • issue: Github issue template generation code needs this to generate the corresponding labels.

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 28, 2023
@codeboten codeboten added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Aug 28, 2023
@sakulali sakulali mentioned this issue Sep 13, 2023
Closed
@songy23 songy23 mentioned this issue Oct 4, 2023
Closed
1 task
@songy23 songy23 mentioned this issue Nov 15, 2023
Closed
1 task
@bogdandrutu
Copy link
Member

Fixed on 22.05

@TylerHelmuth TylerHelmuth mentioned this issue Dec 19, 2023
Merged
@TylerHelmuth
Copy link
Member

This issue is not solved yet

@TylerHelmuth TylerHelmuth reopened this Dec 19, 2023
@TylerHelmuth TylerHelmuth mentioned this issue Dec 19, 2023
Closed
1 task
@songy23 songy23 mentioned this issue Dec 19, 2023
Merged
1 task
@cwegener
Copy link
Contributor

Are there any examples of the failures? The original links that Dmitrii posted are expired and there's no way to see the failures.

@TylerHelmuth
Copy link
Member

Here is one: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7266701238/job/19799801676

@cwegener
Copy link
Contributor

Thanks. I guess this comment is related to the failure too?

#23816 (comment)

No there was an issue w/ cgroups permission + docker socket in the latest ubuntu. I tested some workaround but couldn't get it to work. I'm guessing we may need to change how rpm/deb packages are built in this repo if we want to see it work....

an alternative i hadn't thought about until just now would be to change those workflows to use the goreleaser since that's what we use in the releases repo anyways.

@cwegener
Copy link
Contributor

cwegener commented Dec 22, 2023 •
edited
Loading

Ok. I understand now.

It's the "running SystemD inside of a container" part that is currently broken during the testing stage of the .deb and .rpm packages.

Edit: Some context.

This line is silently failing and the test.sh script is (incorrectly) moving on to the next line. As a first step, there probably should be another step after docker run and before copying the binaries that checks if the container is actually ready.

opentelemetry-collector-contrib/internal/buildscripts/packaging/fpm/test.sh

Lines 43 to 44 in dc787b6

$docker_run
install_pkg $container_name "$PKG_PATH"

cwegener pushed a commit to cwegener/opentelemetry-collector-contrib that referenced this issue Dec 24, 2023
@cwegener
[chore]: fix linux packaging tests
13ccf10 
Fixes open-telemetry#16450

The original packaging tests for the Linux packages (deb, rpm) that were
created in open-telemetry#405 used a bit of gnarly work around in order to allow very
limited Systemd functionality to be used in Docker/Containerd

At the time when those packaging tests were written, podman was already
able to run Systemd, but podman was not included in Ubuntu 20.04 yet ...

Now that Podman is available in Ubuntu 22.04, running SystemD in Podman
just works.

Signed-off-by: Christoph Wegener <cwegener@users.noreply.github.com>
@cwegener cwegener mentioned this issue Dec 24, 2023
Closed
cwegener added a commit to cwegener/opentelemetry-collector-contrib that referenced this issue Dec 24, 2023
@cwegener
[chore]: fix linux packaging tests
9f7f16e 
Fixes open-telemetry#16450

The original packaging tests for the Linux packages (deb, rpm) that were
created in open-telemetry#405 used a bit of gnarly work around in order to allow very
limited Systemd functionality to be used in Docker/Containerd

At the time when those packaging tests were written, podman was already
able to run Systemd, but podman was not included in Ubuntu 20.04 yet ...

Now that Podman is available in Ubuntu 22.04, running SystemD in Podman
just works.

Signed-off-by: Christoph Wegener <cwegener@users.noreply.github.com>
@cwegener cwegener mentioned this issue Dec 24, 2023
Merged
@cwegener
Copy link
Contributor

I published a fix in #30202

@cwegener cwegener mentioned this issue Jan 1, 2024
Closed
codeboten pushed a commit that referenced this issue Jan 8, 2024
@cwegener
[chore]: fix linux packaging tests (#30202)
7917bb2 
Fixes #16450

The original packaging tests for the Linux packages (deb, rpm) that were
created in #405 used a bit of gnarly work around in order to allow very
limited Systemd functionality to be used in Docker/Containerd

At the time when those packaging tests were written, podman was already
able to run Systemd, but podman was not included in Ubuntu 20.04 yet ...

Now that Podman is available in Ubuntu 22.04, running SystemD in Podman
just works.

Signed-off-by: Christoph Wegener <cwegener@users.noreply.github.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
@cwegener @cparkins
[chore]: fix linux packaging tests (open-telemetry#30202)
34c95dd 
Fixes open-telemetry#16450

The original packaging tests for the Linux packages (deb, rpm) that were
created in open-telemetry#405 used a bit of gnarly work around in order to allow very
limited Systemd functionality to be used in Docker/Containerd

At the time when those packaging tests were written, podman was already
able to run Systemd, but podman was not included in Ubuntu 20.04 yet ...

Now that Podman is available in Ubuntu 22.04, running SystemD in Podman
just works.

Signed-off-by: Christoph Wegener <cwegener@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
bug Something isn't working ci-cd CI, CD, testing, build issues good first issue Good for newcomers help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium
Projects
None yet
Milestone
No milestone
6 participants
@codeboten @bogdandrutu @cwegener @dmitryax @TylerHelmuth @jlabatut