Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial deb and rpm packaging #405

Merged
merged 6 commits into from
Jul 15, 2020
Merged

Conversation

jchengsfx
Copy link
Contributor

@jchengsfx jchengsfx commented Jul 7, 2020

Description:

  • Uses https://github.com/jordansissel/fpm
  • Adds deb-package and rpm-package targets to Makefile
  • Builds simple deb and rpm packages that installs the otelcontribcol
    binary to /usr/bin/otelcontribcol
  • Adds deb and rpm packages to circleci workspace for github release
  • Installs otel-contrib-collector systemd service and run as otel:otel user:group

Testing:

  • Added simple installation test after package build using systemd-in-docker images

Documentation:

  • Added deb/README.md and rpm/README.md

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #405 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   85.16%   85.16%           
=======================================
  Files         177      177           
  Lines        9505     9505           
=======================================
  Hits         8095     8095           
  Misses       1089     1089           
  Partials      321      321           
Flag Coverage Δ
#integration 71.09% <ø> (ø)
#unit 84.96% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a25486...0693871. Read the comment docs.

@jchengsfx jchengsfx marked this pull request as ready for review July 8, 2020 15:09
@jchengsfx jchengsfx requested a review from a team July 8, 2020 15:09
Copy link
Contributor

@owais owais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also want to publish deb/rpm packages for ARM?

.circleci/config.yml Outdated Show resolved Hide resolved
packaging/deb/build.sh Outdated Show resolved Hide resolved
@jchengsfx
Copy link
Contributor Author

Don't we also want to publish deb/rpm packages for ARM?

Good point. Will update to build ARM packages as well.

@owais
Copy link
Contributor

owais commented Jul 15, 2020

@jchengsfx can you update this PR to reflect the changes introduced in open-telemetry/opentelemetry-collector#1360? Let's merge this today before we release v0.6

@owais owais mentioned this pull request Jul 15, 2020
Closed
owais and others added 5 commits July 15, 2020 17:59
- Uses https://github.com/jordansissel/fpm
- Adds `deb-package` and `rpm-package` targets to Makefile
- Builds simple deb and rpm packages that installs the otelcontribcol
binary to `/usr/bin/otelcontribcol`
- Adds deb and rpm packages to circleci workspace for github release
- TODO: create service scripts
- Add support for arm64 packages
- Move files to internal/buildscripts/packaging/
- Use single Dockerfile for local deb and rpm builds
- Explicitly set output dir for packages in circleci
- Install `otel-contrib-collector` systemd service and run as `otel:otel` user:group
- Add simple installation test scripts using systemd-in-docker images
@pjanotti pjanotti merged commit d1598f3 into open-telemetry:master Jul 15, 2020
@jchengsfx jchengsfx deleted the deb-rpm branch July 15, 2020 14:52
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
…405)

* migrate code base to use "github.com/stretchr/testify/require" in receiver/zipkinreceiver

* use require.Equal and replase t.Error with require
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
codeboten pushed a commit that referenced this pull request Nov 23, 2022
Based on the OpenCensus agent exporter.

Fixes #343

Co-authored-by: Chris Kleinknecht <libc@google.com>
cwegener pushed a commit to cwegener/opentelemetry-collector-contrib that referenced this pull request Dec 24, 2023
Fixes open-telemetry#16450

The original packaging tests for the Linux packages (deb, rpm) that were
created in open-telemetry#405 used a bit of gnarly work around in order to allow very
limited Systemd functionality to be used in Docker/Containerd

At the time when those packaging tests were written, podman was already
able to run Systemd, but podman was not included in Ubuntu 20.04 yet ...

Now that Podman is available in Ubuntu 22.04, running SystemD in Podman
just works.

Signed-off-by: Christoph Wegener <cwegener@users.noreply.github.com>
cwegener added a commit to cwegener/opentelemetry-collector-contrib that referenced this pull request Dec 24, 2023
Fixes open-telemetry#16450

The original packaging tests for the Linux packages (deb, rpm) that were
created in open-telemetry#405 used a bit of gnarly work around in order to allow very
limited Systemd functionality to be used in Docker/Containerd

At the time when those packaging tests were written, podman was already
able to run Systemd, but podman was not included in Ubuntu 20.04 yet ...

Now that Podman is available in Ubuntu 22.04, running SystemD in Podman
just works.

Signed-off-by: Christoph Wegener <cwegener@users.noreply.github.com>
codeboten pushed a commit that referenced this pull request Jan 8, 2024
Fixes #16450

The original packaging tests for the Linux packages (deb, rpm) that were
created in #405 used a bit of gnarly work around in order to allow very
limited Systemd functionality to be used in Docker/Containerd

At the time when those packaging tests were written, podman was already
able to run Systemd, but podman was not included in Ubuntu 20.04 yet ...

Now that Podman is available in Ubuntu 22.04, running SystemD in Podman
just works.

Signed-off-by: Christoph Wegener <cwegener@users.noreply.github.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
Fixes open-telemetry#16450

The original packaging tests for the Linux packages (deb, rpm) that were
created in open-telemetry#405 used a bit of gnarly work around in order to allow very
limited Systemd functionality to be used in Docker/Containerd

At the time when those packaging tests were written, podman was already
able to run Systemd, but podman was not included in Ubuntu 20.04 yet ...

Now that Podman is available in Ubuntu 22.04, running SystemD in Podman
just works.

Signed-off-by: Christoph Wegener <cwegener@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants