Force systems with kernel option "quiet" to display TTY password prompt #9731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghfields
force-pushed
the
initramfs-quiet-prompt
branch
from
460f09b
to
dfb9c6d
Compare
The #9723 fixes allow certain systems (Ubuntu) to avoid needing to go to TTY prompting. This PR, however fixes systems that do utilize TTY and have "quiet" has the kernel option set. With #9723, there are fewer systems, but doesn't eliminate all TTY use cases. |
rlaager
suggested changes
Dec 17, 2019
contrib/initramfs/scripts/zfs.in
Outdated
|
|
||
| # If root dataset is encrypted... | ||
| if ! [ "${ENCRYPTIONROOT}" = "-" ]; then | ||
| KEYSTATUS="$(${ZFS} get -H -o value keystatus "${ENCRYPTIONROOT}")" | ||
| KEYSTATUS="$(get_fs_value "${ENCRYPTIONROOT}" keystatus)" |
There was a problem hiding this comment.
Personally, I'd prefer these be in separate commits (one PR seems fine), since they're unrelated.
There was a problem hiding this comment.
Yea, was back and forth about if they were trivial enough with myself. Additional PR inbound shortly.
There was a problem hiding this comment.
Done. Became #9736
|
Other than eliminating the unnecessary |
ghfields
force-pushed
the
initramfs-quiet-prompt
branch
from
dfb9c6d
to
ee722f0
Compare
rlaager
approved these changes
Dec 17, 2019
ghfields
force-pushed
the
initramfs-quiet-prompt
branch
from
ee722f0
to
95d3be6
Compare
Signed-off-by: Garrett Fields <ghfields@gmail.com>
ghfields
force-pushed
the
initramfs-quiet-prompt
branch
from
95d3be6
to
a7adede
Compare
rlaager
approved these changes
Dec 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #9731 +/- ##
==========================================
+ Coverage 67% 79% +13%
==========================================
Files 338 420 +82
Lines 106419 123654 +17235
==========================================
+ Hits 71086 98083 +26997
+ Misses 35333 25571 -9762
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Dec 17, 2019
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 26, 2019
On systems that utilize TTY for password entry, if the kernel option "quiet" is set, the system would appear to freeze on a blank screen, when in fact it is waiting for password entry from the user. Since TTY is the fallback method, this has no effect on systemd or plymouth password prompting. By temporarily setting "printk" to "7", running the command, then resuming with the original "printk" state, the user can see the password prompt. Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Garrett Fields <ghfields@gmail.com> Closes openzfs#9731
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
On systems that utilize TTY for password entry, if the kernel option "quiet" is set, the system would appear to freeze on a blank screen, when in fact it is waiting for password entry from the user. Since TTY is the fallback method, this has no effect on systemd or plymouth password prompting. By temporarily setting "printk" to "7", running the command, then resuming with the original "printk" state, the user can see the password prompt. Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Garrett Fields <ghfields@gmail.com> Closes openzfs#9731
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
On systems that utilize TTY for password entry, if the kernel option "quiet" is set, the system would appear to freeze on a blank screen, when in fact it is waiting for password entry from the user. Since TTY is the fallback method, this has no effect on systemd or plymouth password prompting. By temporarily setting "printk" to "7", running the command, then resuming with the original "printk" state, the user can see the password prompt. Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Garrett Fields <ghfields@gmail.com> Closes #9731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
On systems that utilize TTY for password entry, if the kernel option "quiet"
is set, the system would appear to freeze on a blank screen, when in fact it is waiting for
password entry from the user.
Since TTY is the fallback method, this has no effect on systemd or plymouth password prompting
Description
By temporarily setting "printk" to "7", running the command, then
resuming with the original "printk" state, the user can see the password prompt.
How Has This Been Tested?
Prompt now successfully displays on my system (Ubuntu 20.04 Daily) with "quiet" on kernel line
Types of changes
Checklist:
Signed-off-by.