Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initramfs uses "get_fs_value()" to look up properties #9736

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Initramfs uses "get_fs_value()" to look up properties #9736

merged 1 commit into from
Dec 18, 2019

Conversation

ghfields
Copy link
Contributor

Motivation and Context

Quick uniformity fix in the initramfs script

Description

Exchanges two "${ZFS} get -H -o value" commands to the initramfs's "get_fs_value()"

How Has This Been Tested?

Tested with manual changes to /usr/share/initramfs-tools/scripts/zfs file, updated initramfs, and reboot

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghfields
Exchanged two "${ZFS} get -H -o value" commands
e7768eb 
Initramfs uses "get_fs_value()" elsewhere

Signed-off-by: Garrett Fields <ghfields@gmail.com>
@ghfields ghfields mentioned this pull request Dec 17, 2019
Merged
12 tasks
@codecov
Copy link

codecov bot commented Dec 17, 2019 •
edited
Loading

Codecov Report

Merging #9736 into master will increase coverage by 13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9736      +/-   ##
==========================================
+ Coverage      67%      79%     +13%     
==========================================
  Files         338      420      +82     
  Lines      106419   123654   +17235     
==========================================
+ Hits        71086    98289   +27203     
+ Misses      35333    25365    -9968
Flag Coverage Δ
#kernel 80% <ø> (?)
#user 67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad97643...e7768eb. Read the comment docs.

@PrivatePuffin
Copy link
Contributor

Nice find!
You'll be amazed how many places use inefficient ways to lookup properties :P

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 18, 2019
@behlendorf behlendorf merged commit b8a899e into openzfs:master Dec 18, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 26, 2019
@ghfields @tonyhutter
Exchanged two "${ZFS} get -H -o value" commands
d0d1a07 
Initramfs uses "get_fs_value()" elsewhere.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Signed-off-by: Garrett Fields <ghfields@gmail.com>
Closes openzfs#9736
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
@ghfields @tonyhutter
Exchanged two "${ZFS} get -H -o value" commands
8341b1c 
Initramfs uses "get_fs_value()" elsewhere.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Signed-off-by: Garrett Fields <ghfields@gmail.com>
Closes openzfs#9736
geppi pushed a commit to geppi/zfs that referenced this pull request Jan 13, 2020
@ghfields
Exchanged two "${ZFS} get -H -o value" commands
e078439 
Initramfs uses "get_fs_value()" elsewhere.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Signed-off-by: Garrett Fields <ghfields@gmail.com>
Closes openzfs#9736
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
@ghfields @tonyhutter
Exchanged two "${ZFS} get -H -o value" commands
78072b7 
Initramfs uses "get_fs_value()" elsewhere.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Signed-off-by: Garrett Fields <ghfields@gmail.com>
Closes #9736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlaager rlaager rlaager approved these changes

@behlendorf behlendorf behlendorf approved these changes

@PrivatePuffin PrivatePuffin PrivatePuffin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghfields @PrivatePuffin @rlaager @behlendorf