Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XmlPropertyTask #1691

Merged
merged 44 commits into from
Jan 25, 2023
Merged

Fix XmlPropertyTask #1691

merged 44 commits into from
Jan 25, 2023

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Jan 23, 2023

Hello, I found a bug in Phing 3 RC4.

This MR will fix XmlPropertyTask:

PHP Fatal error: Uncaught TypeError: count(): Argument # 1 ($value) must be of type Countable|array, string given in phar:///usr/local/bin/phing/src/Phing/Io/XmlFileParser.php:94

I also added a small test.
Please let me know if I have to change anything.

jawira and others added 30 commits February 11, 2019 14:27
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #1691 (6544553) into main (ef98fae) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1691      +/-   ##
============================================
+ Coverage     57.69%   57.97%   +0.27%     
  Complexity     7009     7009              
============================================
  Files           356      356              
  Lines         17433    17433              
============================================
+ Hits          10058    10106      +48     
+ Misses         7375     7327      -48     
Impacted Files Coverage Δ
src/Phing/Io/XmlFileParser.php 78.57% <100.00%> (+78.57%) ⬆️
src/Phing/Util/Properties.php 69.13% <0.00%> (+2.46%) ⬆️
src/Phing/Task/System/XmlPropertyTask.php 37.14% <0.00%> (+37.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mrook mrook added this to the 3.0.0-RC5 milestone Jan 25, 2023
@mrook mrook merged commit 94cdf79 into phingofficial:main Jan 25, 2023
@jawira jawira deleted the fix-XmlPropertyTask branch January 25, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants