Fix XmlPropertyTask

src/Phing/Io/XmlFileParser.php

@@ -91,7 +91,7 @@ private function getProperties(File $file)
 
             $prefix = implode('.', $path);
 
-            if (count($prefix) > 0) {
+            if (strlen($prefix) > 0) {
                 $prefix .= '.';
             }
 

tests/Phing/Task/System/Property/XmlPropertyTaskTest.php

@@ -0,0 +1,47 @@
+<?php
+
+/**
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * This software consists of voluntary contributions made by many individuals
+ * and is licensed under the LGPL. For more information please see
+ * <http://phing.info>.
+ */
+
+namespace Phing\Task\System\Property;
+
+use Phing\Test\Support\BuildFileTest;
+
+/**
+ * Tests XmlPropertyTask.
+ *
+ * @author  Jawira Portugal
+ *
+ * @internal
+ */
+class XmlPropertyTaskTest extends BuildFileTest
+{
+    public function setUp(): void
+    {
+        $this->configureProject(
+            PHING_TEST_BASE . '/etc/tasks/system/XmlPropertyTaskTest.xml'
+        );
+    }
+
+    public function testXmlPropertyFile(): void
+    {
+        $this->executeTarget(__FUNCTION__);
+        $this->assertPropertyEquals('config.username', 'optimus');
+        $this->assertPropertyEquals('config.temp-dir', 'downloads');
+    }
+}

tests/etc/tasks/properties.xml

@@ -0,0 +1,4 @@
+<config>
+    <username>optimus</username>
+    <temp-dir>downloads</temp-dir>
+</config>

tests/etc/tasks/system/XmlPropertyTaskTest.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project name="XmlPropertyTaskTest" default="testXmlPropertyFile" basedir=".">
+
+    <target name="testXmlPropertyFile" description="Loading properties with XmlPropertyTask">
+        <xmlproperty file="../properties.xml"/>
+        <echo>Username: ${config.username}</echo>
+        <echo>Temp dir: ${config.temp-dir}</echo>
+    </target>
+
+</project>