Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binaries path should be last in the priority lookup list (ENV PATH) #56

Closed
Mzack9999 opened this issue Jan 24, 2023 · 0 comments · Fixed by #63
Closed

binaries path should be last in the priority lookup list (ENV PATH) #56

Mzack9999 opened this issue Jan 24, 2023 · 0 comments · Fixed by #63
Assignees
@xm1k3
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone
pdtm v0.0.4

Comments

@Mzack9999
Copy link
Member

pdtm version:

main|dev

Current Behavior:

The pdtm binaries path is prefixed to all others, erroneously giving priority of execution to those binaries located in the newly added directory:

pdtm/pkg/path/unix.go

Line 38 in 277a879

script := fmt.Sprintf("export PATH=%s:$PATH\n\n", path)

Expected Behavior:

The path should be added as a suffix, leaving the current priority list intact.
@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 24, 2023
@Mzack9999 Mzack9999 changed the title PATH should be last in the priority lookup list binaries path should be last in the priority lookup list (ENV PATH) Jan 24, 2023
@xm1k3 xm1k3 self-assigned this Jan 31, 2023
@xm1k3 xm1k3 linked a pull request Jan 31, 2023 that will close this issue
env path as suffix (#56) #63
Merged
Mzack9999 added a commit that referenced this issue Feb 2, 2023
@Mzack9999
Merge pull request #63 from projectdiscovery/issue-56-env-path-suffix
63e1d6d 
env path as suffix (#56)
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Feb 2, 2023
@ehsandeep ehsandeep added this to the pdtm v0.0.4 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xm1k3 xm1k3

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
pdtm v0.0.4
Development

Successfully merging a pull request may close this issue.

env path as suffix (#56) projectdiscovery/pdtm
3 participants
@ehsandeep @Mzack9999 @xm1k3