Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env path as suffix (#56) #63

Merged
merged 2 commits into from
Feb 2, 2023
Merged

env path as suffix (#56) #63

merged 2 commits into from
Feb 2, 2023

Conversation

xm1k3
Copy link
Contributor

@xm1k3 xm1k3 commented Jan 31, 2023

export PATH=$PATH:%s

@xm1k3 xm1k3 changed the base branch from main to dev January 31, 2023 09:23
@xm1k3 xm1k3 self-assigned this Jan 31, 2023
@xm1k3 xm1k3 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 31, 2023
@xm1k3 xm1k3 linked an issue Jan 31, 2023 that may be closed by this pull request
binaries path should be last in the priority lookup list (ENV PATH) #56
Closed
@xm1k3 xm1k3 marked this pull request as ready for review January 31, 2023 17:16
@xm1k3 xm1k3 requested a review from Mzack9999 January 31, 2023 17:47
Mzack9999
Mzack9999 requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also windows needs to be handled -

pdtm/pkg/path/windows.go

Line 38 in e73f6ee

cur = append([]string{p}, cur...)

@xm1k3 xm1k3 requested a review from Mzack9999 February 1, 2023 14:12
@Mzack9999 Mzack9999 merged commit 63e1d6d into dev Feb 2, 2023
@Mzack9999 Mzack9999 deleted the issue-56-env-path-suffix branch February 2, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@xm1k3 xm1k3

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

binaries path should be last in the priority lookup list (ENV PATH)
2 participants
@xm1k3 @Mzack9999