Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows title bar tweaks #142

Closed
wants to merge 8 commits into from

Conversation

Valer100
Copy link
Contributor

@Valer100 Valer100 commented Jun 28, 2024

Hi! In this PR I made sv_ttk change the color of the title bar to match the light or dark theme on Windows. Here are some screenshots:

Windows 11 Light

w11-light

Windows 11 Dark

w11-dark

Windows 10 Light

win10_light

Windows 10 Dark

win10_dark

Due to Windows 10 limitations, you can't set a custom title bar color. Instead, it can only be set to black in dark mode and white in light mode. On Windows 11 you can set its color to any color.

I made this PR also change the Toplevel windows' title bar color. Here are some screen recordings:

Windows.11.mp4
Windows.10.mp4

@rdbende
Copy link
Owner

rdbende commented Jul 8, 2024

Hi, and thanks for your contribution!

The code looks good to me, but I'm not sure I want to accept this feature to sv-ttk. In the past I've rejected multiple pull requests adding this functionality, and the reason is simple: sv-ttk is a simple ttk theme, that I wrapped in a Pypi package for convenience. I don't want to add other dependencies, nor features that would be trival to implement if the user wants it, using third party packages, like pywinstyles itself. I also don't use Windows, and wouldn't have any kind of capacity to maintain this feature.

This is why I didn't integrate darkdetect, and I'm also not keen on adding titlebar coloring, especially as it would be a Windows-only feature.

@rdbende
Copy link
Owner

rdbende commented Jul 8, 2024

I would however welcome changes to the README, that explain how to integrate sv-ttk with pywinstyles or darkdetect

@Valer100
Copy link
Contributor Author

Valer100 commented Jul 8, 2024

I understand that's hard for you to maintain a feature like this and that your goal is just to make a simple ttk theme. But your idea to explain in README how to integrate the theme with 3rd party modules like pywinstyles and darkdetect is also a good one.

@HuyHung1408
Copy link

I'm interested if you can set up a repo for it. Pretty neat!

@Valer100 Valer100 closed this Jul 28, 2024
@jhi2
Copy link

jhi2 commented Jul 29, 2024

you can use nativesvttk if you want this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants