Explain in README.md how to integrate sv_ttk with 3rd party modules #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm on mobile right now, but I will review this in detail when I get to a computer. |
|
OK 👍 |
|
@rdbende Can you check it now? |
rdbende
requested changes
Jul 27, 2024
Co-authored-by: Benedek Dévényi <rdbende@proton.me>
Co-authored-by: Benedek Dévényi <rdbende@proton.me>
Co-authored-by: Benedek Dévényi <rdbende@proton.me>
rdbende
reviewed
Jul 27, 2024
|
I'm not going to care about the outdated Github Actions checks. This is just a README update. |
|
This looks great! Thanks for your work! |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! In #142 you said that you're not sure you want to accept the changes in it to sv-ttk. But you said that changes to README that explain how to integrate the theme with 3rd party modules are welcome. This PR changes the README file to explain how to integrate the theme with
pywinstyleanddarkdetectmodules. I hope you will like the changes.