Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): refactoring FromSchema out of core #787

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix(core): refactoring FromSchema out of core #787

merged 2 commits into from
Oct 25, 2023

Conversation

erunion
Copy link
Member

@erunion erunion commented Oct 25, 2023 •
edited
Loading

🚥 Resolves RM-8230

🧰 Changes

We've been having a lot of typing issues with FromSchema since my refactor in #764 so I'm reverting that work and making json-schema-to-ts an explicit dependency on codegen'd SDKs again.

@erunion erunion added this to the v7 milestone Oct 25, 2023
@erunion erunion added bug Something isn't working area:core Issues related to `core`, which is the package that powers the SDKs at runtime labels Oct 25, 2023
@erunion erunion marked this pull request as ready for review October 25, 2023 19:20
@erunion erunion changed the title fix(core): moving our FromSchema exports into the types file fix(core): refactoring FromSchema out of core Oct 25, 2023
@erunion erunion marked this pull request as draft October 25, 2023 19:54
@erunion erunion marked this pull request as ready for review October 25, 2023 20:11
kanadgupta
kanadgupta approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😔

@erunion erunion merged commit 41cacf3 into main Oct 25, 2023
5 checks passed
@erunion erunion deleted the fix/typing-issues branch October 25, 2023 20:52
kanadgupta added a commit that referenced this pull request Oct 31, 2023
@kanadgupta
Revert "fix(core): refactoring FromSchema out of core (#787)"
17ab40b 
This reverts commit 41cacf3.
@kanadgupta kanadgupta mentioned this pull request Oct 31, 2023
Merged
kanadgupta added a commit that referenced this pull request Oct 31, 2023
@kanadgupta
feat(core): bring FromSchema back into core (#801)
f7679f4 
* Revert "fix(core): refactoring  `FromSchema` out of core (#787)"

This reverts commit 41cacf3.

* refactor: move FromSchema to types file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanadgupta kanadgupta kanadgupta approved these changes

Assignees
No one assigned
Labels
area:core Issues related to `core`, which is the package that powers the SDKs at runtime bug Something isn't working
Projects
None yet
Milestone
v7
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @kanadgupta