Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): bring FromSchema back into core #801

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat(core): bring FromSchema back into core #801

merged 2 commits into from
Oct 31, 2023

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Oct 31, 2023 •
edited
Loading

Turns out all those typing issues we were seeing earlier was just a stupid mirage so we can once again hide FromSchema in our core exports! (reverts #787)

Confirmed that attw is happy:

CleanShot 2023-10-31 at 13 53 40@2x

Tagging RM-8230 for posterity

@kanadgupta kanadgupta added enhancement New feature or request area:core Issues related to `core`, which is the package that powers the SDKs at runtime area:api Issues related to the `api` CLI, which builds the SDKs labels Oct 31, 2023
@kanadgupta kanadgupta marked this pull request as ready for review October 31, 2023 18:53
@kanadgupta kanadgupta merged commit f7679f4 into main Oct 31, 2023
5 checks passed
@kanadgupta kanadgupta deleted the revert-787-fix/typing-issues branch October 31, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
area:api Issues related to the `api` CLI, which builds the SDKs area:core Issues related to `core`, which is the package that powers the SDKs at runtime enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanadgupta @erunion