Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Adding tests detecting changed paths in utils/paths.rs #6047

Open
tesuji opened this issue Sep 15, 2020 · 1 comment
Open

CI: Adding tests detecting changed paths in utils/paths.rs #6047

tesuji opened this issue Sep 15, 2020 · 1 comment
Labels
A-infra Area: CI issues and issues that require full access for GitHub/CI L-tests Lint: Lints test code

Comments

@tesuji
Copy link
Contributor

tesuji commented Sep 15, 2020

It caused hard-to-debug test fallings like this: https://github.com/rust-lang-ci/rust/runs/1116251535#step:23:9212
Would be better to catch this earlier before compiling or running tests.
@tesuji tesuji mentioned this issue Sep 15, 2020
Merged
@flip1995 flip1995 changed the title CI: Adding tests detects changed path in utils/paths.rs CI: Adding tests detecting changed paths in utils/paths.rs Sep 15, 2020
@flip1995 flip1995 added L-tests Lint: Lints test code A-infra Area: CI issues and issues that require full access for GitHub/CI labels Sep 15, 2020
@ghost
Copy link

ghost commented Oct 26, 2020

I'm working on an internal lint to do this. Should have a pull request soon.

@ghost ghost mentioned this issue Oct 27, 2020
Merged
bors added a commit that referenced this issue Oct 27, 2020
@bors
Auto merge of #6244 - mikerite:invalid_paths_20201027, r=flip1995
8823684 
New internal lint: Invalid paths

Add a new internal lint that detects invalid paths in the `util::paths` and fix some invalid paths found.

This commit partially addresses #6047 but the lint would have to be run before running tests to close that issue.

changelog: none
@ebroto ebroto mentioned this issue Oct 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-infra Area: CI issues and issues that require full access for GitHub/CI L-tests Lint: Lints test code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flip1995 @tesuji