Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New internal lint: Invalid paths #6244

Merged
merged 2 commits into from Oct 27, 2020
Merged

New internal lint: Invalid paths #6244

merged 2 commits into from Oct 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 27, 2020

Add a new internal lint that detects invalid paths in the util::paths and fix some invalid paths found.

This commit partially addresses #6047 but the lint would have to be run before running tests to close that issue.

changelog: none

@rust-highfive
Copy link

r? @ebroto

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 27, 2020
@ghost ghost changed the title Invalid paths 20201027 New internal lint: Invalid paths Oct 27, 2020
@flip1995
Copy link
Member

but the lint would have to be run before running tests to close that issue.

And the dogfood test is not run in the Rust repo at all. But this is great to have either way! Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 27, 2020

📌 Commit f79c4af has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Oct 27, 2020

⌛ Testing commit f79c4af with merge 8823684...

@bors
Copy link
Collaborator

bors commented Oct 27, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8823684 to master...

@bors bors merged commit 8823684 into rust-lang:master Oct 27, 2020
@ghost ghost deleted the invalid_paths_20201027 branch October 29, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants