Sync rustc_codegen_cranelift #113960
Merged
Sync rustc_codegen_cranelift #113960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except for mir inlining all mir opts that are beneficial for cg_clif now run on -Zmir-opt-level=2. -Zmir-opt-level=3 enables some more expensive optimizations.
…sg, r=b-naber Better error for non const `PartialEq` call generated by `match` Resolves rust-lang#90237
rustbot
added
S-waiting-on-review
|
@bors r+ p=1 subtree sync |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-testsuite
|
@bors r+ p=1 subtree sync |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (ab0f3e6): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 651.03s -> 651.513s (0.07%) |
vi
reviewed
Jan 17, 2024
example/mini_core.rs
Outdated
| @@ -563,11 +564,6 @@ unsafe fn allocate(size: usize, _align: usize) -> *mut u8 { | |||
| libc::malloc(size) | |||
| } | |||
|
|
|||
| #[lang = "box_free"] | |||
| unsafe fn box_free<T: ?Sized>(ptr: Unique<T>, _alloc: ()) { | |||
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 26, 2024
…strieb Fix outdated comment on Box Caught by `@vi` in rust-lang#113960 (comment)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 26, 2024
Rollup merge of rust-lang#120372 - bjorn3:fix_outdated_comment, r=Nilstrieb Fix outdated comment on Box Caught by `@vi` in rust-lang#113960 (comment)
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
Fix outdated comment on Box Caught by `@vi` in rust-lang/rust#113960 (comment)
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
Fix outdated comment on Box Caught by `@vi` in rust-lang/rust#113960 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time Cranelift has been updated to 0.98. A couple of bugs have been fixed and a decent amount of x86 vendor intrinsics have been implemented.
r? @ghost
@rustbot label +A-codegen +A-cranelift +T-compiler