Rollup of 8 pull requests #115758
Merged
Rollup of 8 pull requests #115758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix overflow in array length computation addressing rust-lang#114912
…ulacrum bootstrap/format: remove unnecessary paths.push Cc rust-lang#106415 (review) I verified that this still formats all fileds when `get_modified_rs_files` is made to return an error. r? ``@Nilstrieb``
…oli-obk Update mailmap rust-lang/team#1071 / rust-lang/thanks#58
… r=oli-obk Implement fallback for effect param r? `@oli-obk` or `@lcnr` tracking issue for this ongoing work: rust-lang#110395
…e, r=oli-obk Call `LateLintPass::check_attribute` from `with_lint_attrs` Fixes rust-lang#115571 For regular `register_late_pass` lints also means that `last_node_with_lint_attrs` is correct when in `check_attribute`, I've added a test that previously failed for `clippy::allow_attributes` As far as I can see the only late lint in rustc that uses `check_attribute` is `unstable_features` which is allow by default and deprecated so this is mostly for clippy (or future rustc lints)
Point out if a local trait has no implementations Slightly helps with rust-lang#115741
Improve diagnostic for generic params from outer items (E0401) Generalize the wording of E0401 to talk about *outer items* instead of *outer functions* since the current phrasing is outdated. The outer item can be a function, constant, trait, ADT or impl block (see the new UI test for the more exotic examples). Further, don't suggest introducing generic parameters to constant items unless the feature `generic_const_items` is enabled. Lastly, make E0401 translatable while we're at it. Fixes rust-lang#115720.
… r=notriddle rustdoc: Add missing "Aliased type" title in the sidebar Follow-up of rust-lang#115682. The sections title are supposed to be present in the sidebar, we forgot to put this one so I added it into it. I also added the missing newly created `aliased-type` ID into the `DEFAULT_ID_MAP`. r? `@notriddle`
rustbot
added
A-meta
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 3ebb5629d1 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Sep 11, 2023
|
Finished benchmarking commit (0a199e4): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 629.503s -> 630.454s (0.15%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
LateLintPass::check_attributefromwith_lint_attrs#115739 (CallLateLintPass::check_attributefromwith_lint_attrs)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup