Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymize binders for refining_impl_trait check #116149

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Sep 25, 2023

We're naively using the equality impl for ty::Clause in the refinement check, which is okay except for binders, which carry some information about where they come from in the AST. Those locations are not gonna be equal between traits and impls, so anonymize those clauses so that this doesn't matter.

Fixes #116135

@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2023

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 25, 2023
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after comment

@compiler-errors
Copy link
Member Author

@bors r=lcnr rollup

@bors
Copy link
Contributor

bors commented Sep 26, 2023

📌 Commit 305524d has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2023
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#115934 (Split out the stable part of smir into its own crate to prevent accidental usage of forever unstable things)
 - rust-lang#116149 (Anonymize binders for `refining_impl_trait` check)
 - rust-lang#116178 (Add test for `const async fn`)
 - rust-lang#116187 (Add context to `let: Ty = loop { break };`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 50417a5 into rust-lang:master Sep 27, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 27, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2023
Rollup merge of rust-lang#116149 - compiler-errors:anonymize, r=lcnr

Anonymize binders for `refining_impl_trait` check

We're naively using the equality impl for `ty::Clause` in the refinement check, which is okay *except* for binders, which carry some information about where they come from in the AST. Those locations are not gonna be equal between traits and impls, so anonymize those clauses so that this doesn't matter.

Fixes rust-lang#116135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPITIT refinement lint false positive when HRTB is involved
4 participants