Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to let: Ty = loop { break }; #116187

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

estebank
Copy link
Contributor

We weren't accounting for the case where break was immediately within the loop block.

We weren't accounting for the case where `break` was immediately within
the `loop` block.
@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 26, 2023
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 27, 2023

📌 Commit 4b15959 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2023
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#115934 (Split out the stable part of smir into its own crate to prevent accidental usage of forever unstable things)
 - rust-lang#116149 (Anonymize binders for `refining_impl_trait` check)
 - rust-lang#116178 (Add test for `const async fn`)
 - rust-lang#116187 (Add context to `let: Ty = loop { break };`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a6f0665 into rust-lang:master Sep 27, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2023
Rollup merge of rust-lang#116187 - estebank:small-tweak, r=compiler-errors

Add context to `let: Ty = loop { break };`

We weren't accounting for the case where `break` was immediately within the `loop` block.
@rustbot rustbot added this to the 1.74.0 milestone Sep 27, 2023
@estebank estebank deleted the small-tweak branch November 9, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants