Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor --print=check-cfg test #125822

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented May 31, 2024

as asked in #125818 (comment)

r? @jieyouxu

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 31, 2024

Some changes occurred in run-make tests.

cc @jieyouxu

@jieyouxu
Copy link
Member

Looks good, r=me after CI is green

@Urgau
Copy link
Member Author

Urgau commented May 31, 2024

@bors r=jieyouxu rollup

@bors
Copy link
Contributor

bors commented May 31, 2024

📌 Commit a7e7848 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2024
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 1, 2024
…t, r=jieyouxu

Refactor `--print=check-cfg` test

*as asked in rust-lang#125818 (comment)

r? `@jieyouxu`
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 1, 2024
…t, r=jieyouxu

Refactor `--print=check-cfg` test

*as asked in rust-lang#125818 (comment)

r? ``@jieyouxu``
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 1, 2024
…t, r=jieyouxu

Refactor `--print=check-cfg` test

*as asked in rust-lang#125818 (comment)

r? ```@jieyouxu```
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 1, 2024
Rollup of 3 pull requests

Successful merges:

 - rust-lang#125211 (Stablize `const_binary_heap_constructor`)
 - rust-lang#125683 (Rewrite `suspicious-library`, `resolve-rename` and `incr-prev-body-beyond-eof` `run-make` tests in `rmake.rs` format)
 - rust-lang#125822 (Refactor `--print=check-cfg` test)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 1, 2024
…t, r=jieyouxu

Refactor `--print=check-cfg` test

*as asked in rust-lang#125818 (comment)

r? ````@jieyouxu````
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 1, 2024
…t, r=jieyouxu

Refactor `--print=check-cfg` test

*as asked in rust-lang#125818 (comment)

r? `````@jieyouxu`````
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 1, 2024
…t, r=jieyouxu

Refactor `--print=check-cfg` test

*as asked in rust-lang#125818 (comment)

r? ``````@jieyouxu``````
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 1, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124294 (Unroll first iteration of checked_ilog loop)
 - rust-lang#125562 (Weekly `cargo update`)
 - rust-lang#125822 (Refactor `--print=check-cfg` test)
 - rust-lang#125856 (include missing submodule on bootstrap)

r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request Jun 1, 2024
…t, r=jieyouxu

Refactor `--print=check-cfg` test

*as asked in rust-lang#125818 (comment)

r? ```````@jieyouxu```````
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 1, 2024
Rollup of 4 pull requests

Successful merges:

 - rust-lang#124294 (Unroll first iteration of checked_ilog loop)
 - rust-lang#125773 (Migrate run make cdylib)
 - rust-lang#125808 (Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs`)
 - rust-lang#125822 (Refactor `--print=check-cfg` test)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Jun 2, 2024

⌛ Testing commit a7e7848 with merge a83cf56...

@bors
Copy link
Contributor

bors commented Jun 2, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing a83cf56 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 2, 2024
@bors bors merged commit a83cf56 into rust-lang:master Jun 2, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone Jun 2, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a83cf56): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% [2.3%, 2.9%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 667.911s -> 667.268s (-0.10%)
Artifact size: 318.88 MiB -> 318.90 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants