include missing submodule on bootstrap

[onur-ozkan]

As of #125408 PR, rustbook now relies on dependencies from the "src/doc/book" submodule.

However, bootstrap does not automatically sync this submodule before reading metadata informations. And if the submodule is not present, reading metadata will fail because rustbook's dependencies will be missing.

This change makes "src/doc/book" to be fetched/synced automatically before trying to read metadata.

cc @Zalathar

[rustbot]

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[onur-ozkan]

This is very simple change and it fixes a contribution roadblock (there are workarounds exist, but people have to put some effort to find them).

So, @bors r+ p=1

[bors]

📌 Commit 5cdec65 has been approved by onur-ozkan

It is now in the queue for this repository.

[Zalathar]

Yeah, this seems worth rushing a trivial fix for.

[ehuss]

Thanks for the fix!

[bors]

⌛ Testing commit 5cdec65 with merge a94483a...

[bors]

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing a94483a to master...

[rust-timer]

Finished benchmarking commit (a94483a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.781s -> 668.545s (-0.04%)
Artifact size: 318.82 MiB -> 318.79 MiB (-0.01%)

[RalfJung]

So it is expected that I now have to check out the books to build rustc? That's unfortunate, I was quite happy I could avoid those submodule updates so far...

Also see Zulip.

[onur-ozkan]

As long as "book" is a submodule and rust sources using it as a dependency (which is the case right now), this change is mandatory.

[RalfJung]

Yes, indeed. The question is whether it's okay for a rust source crate to depend on code inside src/doc -- my expectation was that that's for docs only, so code should be independent of it.

[chriskrycho]

Aggghhh. Messy. I am happy to back out the change and publish those crates instead of using path deps if that is a better approach that avoids ongoing issues here (had no idea this would be an issue, and alas, @ehuss missed it too).

[Zalathar]

Yeah, checking out src/doc/book was a quick-fix to unbreak bootstrap, but if we can revert #125408 and achieve the same result in a different way then I think that would be better long-term.

[RalfJung]

I'd say discuss this with t-compiler -- if they say it's okay to have such dependencies I'll live with it. But IMO it's worth discussing at least.

[chriskrycho]

Started a Zulip discussion on this with t-compiler!