Explain why non_snake_case is skipped for binary crates and cleanup tests

[jieyouxu]

• Explain non_snake_case lint is skipped for bin crate names because binaries are not intended to be distributed or consumed like library crates (Don't enforce snake_case for binary names #45127).
• Coalesce the bunch of tests into a single one but with revisions, which is easier to compare the differences for non_snake_case behavior with respect to crate types.

Follow-up to #121749 with some more comments and test cleanup.

cc @saethlin who bumped into one of the tests and was confused why it was only-x86_64-unknown-linux-gnu.

try-job: dist-i586-gnu-i586-i686-musl

[rustbot]

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[jieyouxu]

@bors rollup=iffy (this might bounce due to unsupported crate types for specific targets, but it's probably better to ignore when necessary instead of just running this for x86_64-unknown-linux-gnu).

[Zalathar]

I notice that this also gets rid of two extra bin tests that set the crate type and crate name in a variety of ways.

I don't object to that, but I just want to double-check that it was intentional.

[jieyouxu]

I notice that this also gets rid of two extra bin tests that set the crate type and crate name in a variety of ways.

I dropped those versions because AFAICT when the check for executable crate type is skipped, the different ways to set crate types/names are indistinguishable to the check as part of a late lint pass. I can add them back in if you think those should be retained.

[Zalathar]

Nah, if there's no reason to think the extra variants will be useful then it seems fine to get rid of them.

[petrochenkov]

r=me with #130599 (comment) answered.
@rustbot author

[petrochenkov]

@bors r+

[bors]

📌 Commit aebc28e has been approved by petrochenkov

It is now in the queue for this repository.

[jieyouxu]

@bors try

[bors]

⌛ Trying commit 9ae1fb4 with merge 883506d...

[bors]

☀️ Try build successful - checks-actions
Build commit: 883506d (883506d9cd1bcb4c442d6823eba69952f7f92be9)

[jieyouxu]

Changes since last review:

• Fix test failure by changing to ignore-musl for both cdylib and dylib (musl AFAIK doesn't support dylibs in general)

@rustbot ready

[petrochenkov]

@bors r+

[bors]

📌 Commit 9ae1fb4 has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9ae1fb4 with merge f48c99a...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing f48c99a to master...

[rust-timer]

Finished benchmarking commit (f48c99a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%, secondary 2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

Cycles

Results (secondary 1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.8%	[1.8%, 1.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.225s -> 768.677s (-0.07%)
Artifact size: 341.35 MiB -> 341.36 MiB (0.00%)