Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain why non_snake_case is skipped for binary crates and cleanup tests #130599

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Explain why non_snake_case is skipped for binary crates and cleanup tests #130599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43ede73
Explain why non_snake_case is skipped for binary crates
jieyouxu Sep 20, 2024
9ae1fb4
Coalesce `non_snake_case` crate test set with revisions
jieyouxu Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate-bin.rs
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate-bin2.rs
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate-bin3.rs
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate-cdylib.rs
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate-dylib.rs
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate-lib.rs
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate-proc-macro.rs
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate-proc-macro.stderr
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate-rlib.rs
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate-staticlib.rs
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate-staticlib.stderr
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...case/lint-non-snake-case-crate-lib.stderr → .../lint-non-snake-case-crate.cdylib_.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
error: crate `NonSnakeCase` should have a snake case name
--> $DIR/lint-non-snake-case-crate-lib.rs:3:18
--> $DIR/lint-non-snake-case-crate.rs:25:18
|
LL | #![crate_name = "NonSnakeCase"]
| ^^^^^^^^^^^^ help: convert the identifier to snake case: `non_snake_case`
|
note: the lint level is defined here
--> $DIR/lint-non-snake-case-crate-lib.rs:5:9
--> $DIR/lint-non-snake-case-crate.rs:27:9
|
LL | #![deny(non_snake_case)]
| ^^^^^^^^^^^^^^
Expand Down
4 changes: 2 additions & 2 deletions ...ase/lint-non-snake-case-crate-rlib.stderr → ...e/lint-non-snake-case-crate.dylib_.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
error: crate `NonSnakeCase` should have a snake case name
--> $DIR/lint-non-snake-case-crate-rlib.rs:3:18
--> $DIR/lint-non-snake-case-crate.rs:25:18
|
LL | #![crate_name = "NonSnakeCase"]
| ^^^^^^^^^^^^ help: convert the identifier to snake case: `non_snake_case`
|
note: the lint level is defined here
--> $DIR/lint-non-snake-case-crate-rlib.rs:5:9
--> $DIR/lint-non-snake-case-crate.rs:27:9
|
LL | #![deny(non_snake_case)]
| ^^^^^^^^^^^^^^
Expand Down
4 changes: 2 additions & 2 deletions ...se/lint-non-snake-case-crate-dylib.stderr → ...ase/lint-non-snake-case-crate.lib_.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
error: crate `NonSnakeCase` should have a snake case name
--> $DIR/lint-non-snake-case-crate-dylib.rs:3:18
--> $DIR/lint-non-snake-case-crate.rs:25:18
|
LL | #![crate_name = "NonSnakeCase"]
| ^^^^^^^^^^^^ help: convert the identifier to snake case: `non_snake_case`
|
note: the lint level is defined here
--> $DIR/lint-non-snake-case-crate-dylib.rs:5:9
--> $DIR/lint-non-snake-case-crate.rs:27:9
|
LL | #![deny(non_snake_case)]
| ^^^^^^^^^^^^^^
Expand Down
4 changes: 2 additions & 2 deletions ...e/lint-non-snake-case-crate-cdylib.stderr → ...t-non-snake-case-crate.proc_macro_.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
error: crate `NonSnakeCase` should have a snake case name
--> $DIR/lint-non-snake-case-crate-cdylib.rs:3:18
--> $DIR/lint-non-snake-case-crate.rs:25:18
|
LL | #![crate_name = "NonSnakeCase"]
| ^^^^^^^^^^^^ help: convert the identifier to snake case: `non_snake_case`
|
note: the lint level is defined here
--> $DIR/lint-non-snake-case-crate-cdylib.rs:5:9
--> $DIR/lint-non-snake-case-crate.rs:27:9
|
LL | #![deny(non_snake_case)]
| ^^^^^^^^^^^^^^
Expand Down
14 changes: 14 additions & 0 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate.rlib_.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
error: crate `NonSnakeCase` should have a snake case name
--> $DIR/lint-non-snake-case-crate.rs:25:18
|
LL | #![crate_name = "NonSnakeCase"]
| ^^^^^^^^^^^^ help: convert the identifier to snake case: `non_snake_case`
|
note: the lint level is defined here
--> $DIR/lint-non-snake-case-crate.rs:27:9
|
LL | #![deny(non_snake_case)]
| ^^^^^^^^^^^^^^

error: aborting due to 1 previous error

29 changes: 29 additions & 0 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
//! Don't lint on binary crate with non-snake-case names.
//!
//! See <https://github.com/rust-lang/rust/issues/45127>.

//@ revisions: bin_ cdylib_ dylib_ lib_ proc_macro_ rlib_ staticlib_
petrochenkov marked this conversation as resolved.
Show resolved Hide resolved

// Should not fire on binary crates.
//@[bin_] compile-flags: --crate-type=bin
//@[bin_] check-pass

// But should fire on non-binary crates.

//@[cdylib_] ignore-musl (dylibs are not supported)
//@[dylib_] ignore-musl (dylibs are not supported)
petrochenkov marked this conversation as resolved.
Show resolved Hide resolved
//@[dylib_] ignore-wasm (dylib is not supported)
//@[proc_macro_] ignore-wasm (dylib is not supported)

//@[cdylib_] compile-flags: --crate-type=cdylib
//@[dylib_] compile-flags: --crate-type=dylib
//@[lib_] compile-flags: --crate-type=lib
//@[proc_macro_] compile-flags: --crate-type=proc-macro
//@[rlib_] compile-flags: --crate-type=rlib
//@[staticlib_] compile-flags: --crate-type=staticlib

#![crate_name = "NonSnakeCase"]
//[cdylib_,dylib_,lib_,proc_macro_,rlib_,staticlib_]~^ ERROR crate `NonSnakeCase` should have a snake case name
#![deny(non_snake_case)]

fn main() {}
14 changes: 14 additions & 0 deletions tests/ui/lint/non-snake-case/lint-non-snake-case-crate.staticlib_.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
error: crate `NonSnakeCase` should have a snake case name
--> $DIR/lint-non-snake-case-crate.rs:25:18
|
LL | #![crate_name = "NonSnakeCase"]
| ^^^^^^^^^^^^ help: convert the identifier to snake case: `non_snake_case`
|
note: the lint level is defined here
--> $DIR/lint-non-snake-case-crate.rs:27:9
|
LL | #![deny(non_snake_case)]
| ^^^^^^^^^^^^^^

error: aborting due to 1 previous error

Loading