Pass Module Analysis Manager to Standard Instrumentations #130850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Cc @rust-lang/wg-llvm |
saveasguy
force-pushed
the
pass-mam-to-standrd-instrumentations
branch
from
4a2253b
to
afb7eef
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 26, 2024
…rumentations, r=nikic Pass Module Analysis Manager to Standard Instrumentations This PR introduces changes related to llvm::PassInstrumentationCallbacks. Now, we pass Module Analysis Manager to StandardInstrumentations::registerCallbacks, so it can take advantage of such instrumentations as IR verifier or preserved CFG checker. So basically this is NFC PR.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#129687 (Implement RFC3137 trim-paths sysroot changes - take 2) - rust-lang#130517 (Add the library workspace to the suggested rust-analyzer config) - rust-lang#130820 (Fix diagnostics for coroutines with () as input.) - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation) - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk) - rust-lang#130850 (Pass Module Analysis Manager to Standard Instrumentations) - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs) - rust-lang#130873 (rustc_target: Add powerpc64 atomic-related features) - rust-lang#130879 (Pass correct HirId to late_bound_vars in diagnostic code) - rust-lang#130880 (add missing FIXME(const-hack)) r? `@ghost` `@rustbot` modify labels: rollup
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 26, 2024
…rumentations, r=nikic Pass Module Analysis Manager to Standard Instrumentations This PR introduces changes related to llvm::PassInstrumentationCallbacks. Now, we pass Module Analysis Manager to StandardInstrumentations::registerCallbacks, so it can take advantage of such instrumentations as IR verifier or preserved CFG checker. So basically this is NFC PR.
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 26, 2024
…rumentations, r=nikic Pass Module Analysis Manager to Standard Instrumentations This PR introduces changes related to llvm::PassInstrumentationCallbacks. Now, we pass Module Analysis Manager to StandardInstrumentations::registerCallbacks, so it can take advantage of such instrumentations as IR verifier or preserved CFG checker. So basically this is NFC PR.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2024
…llaumeGomez Rollup of 11 pull requests Successful merges: - rust-lang#130279 (Document subtleties of `ManuallyDrop`) - rust-lang#130517 (Add the library workspace to the suggested rust-analyzer config) - rust-lang#130820 (Fix diagnostics for coroutines with () as input.) - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation) - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk) - rust-lang#130850 (Pass Module Analysis Manager to Standard Instrumentations) - rust-lang#130861 (Use `mem::offset_of!` for `sockaddr_un.sun_path`) - rust-lang#130862 (rustdoc: do not animate :target when user prefers reduced motion) - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs) - rust-lang#130879 (Pass correct HirId to late_bound_vars in diagnostic code) - rust-lang#130880 (add missing FIXME(const-hack)) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
Rollup merge of rust-lang#130850 - saveasguy:pass-mam-to-standrd-instrumentations, r=nikic Pass Module Analysis Manager to Standard Instrumentations This PR introduces changes related to llvm::PassInstrumentationCallbacks. Now, we pass Module Analysis Manager to StandardInstrumentations::registerCallbacks, so it can take advantage of such instrumentations as IR verifier or preserved CFG checker. So basically this is NFC PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes related to llvm::PassInstrumentationCallbacks. Now, we pass Module Analysis Manager to StandardInstrumentations::registerCallbacks, so it can take advantage of such instrumentations as IR verifier or preserved CFG checker. So basically this is NFC PR.