[liballoc] Adds checks for UB during allocation. #25254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're only enabled in debug builds, but a panic is usually more welcome than UB in debug builds.
|
I think you mean @huonw ;) |
|
I'm a fan of this. Wanna discuss with some others what exactly we "want" out of debug asserts. Particularly in unsafe vs safe APIs. |
|
So discussing with @alexcrichton it seems like a stable release will have all of these stripped irreversibly. These will only be "active" for basically compiler-compilers and people rolling a custom build with debug enabled. As such I think this is fine to land. |
|
@bors r+ rollup |
|
📌 Commit 101b25c has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 11, 2015
…Gankro They're only enabled in debug builds, but a panic is usually more welcome than UB in debug builds. Previous review at rust-lang#22069 r? @gankro cc @huon
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 12, 2015
…Gankro They're only enabled in debug builds, but a panic is usually more welcome than UB in debug builds. Previous review at rust-lang#22069 r? @gankro cc @huon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're only enabled in debug builds, but a panic is usually more
welcome than UB in debug builds.
Previous review at #22069
r? @gankro
cc @huon