Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BitSet docs with correct types #25288

Merged
merged 1 commit into from
May 12, 2015
Merged

Update BitSet docs with correct types #25288

merged 1 commit into from
May 12, 2015

Conversation

DrKwint
Copy link
Contributor

@DrKwint DrKwint commented May 10, 2015

The functions BitSet::{iter,union,symmetric_difference} each had docs that claimed u32s were output when their actual output each end up being usizes.

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

Thank you for this PR! there's three things:

  1. there's an extra file in here for some reason
  2. when you fix that, can you squash as well
  3. I'm good to merge this afterward, which means you should comment over at 1.0 release notes and authors updates #25196 so you can get in AUTHORS

Update BitSet docs to correct type in one more spot

removed accidental file
@DrKwint
Copy link
Contributor Author

DrKwint commented May 11, 2015

Sorry, I'm not terribly experienced with Git. I think I've fixed it though. r? @steveklabnik

@alexcrichton
Copy link
Member

@bors: r+ c98df58 rollup

Thanks!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 11, 2015
The functions BitSet::{iter,union,symmetric_difference} each had docs that claimed u32s were output when their actual output each end up being usizes.

r? @steveklabnik
bors added a commit that referenced this pull request May 11, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 12, 2015
The functions BitSet::{iter,union,symmetric_difference} each had docs that claimed u32s were output when their actual output each end up being usizes.

r? @steveklabnik
bors added a commit that referenced this pull request May 12, 2015
@bors bors merged commit c98df58 into rust-lang:master May 12, 2015
@steveklabnik steveklabnik mentioned this pull request May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants