rustbuild: install improvements #42067
Conversation
aidanhs
added
the
S-waiting-on-author
|
Hi @Keruspe, thanks for the PR! Looks like this failed CI because you have some long lines: |
src/bootstrap/install.rs
Outdated
| &mandir, &empty_dir); | ||
|
|
||
| t!(fs::remove_dir_all(&empty_dir)); | ||
| } | ||
|
|
||
| fn install_sh(build: &Build, package: &str, name: &str, version: &str, stage: u32, host: &str, | ||
| fn install_sh(build: &Build, package: &str, name: &str, version: &str, stage: u32, host: Option<&str>, |
There was a problem hiding this comment.
Mind doing a bit of refactoring while you're here? I feel like a function which takes 13 arguments is... odd
src/bootstrap/config.toml.example
Outdated
| @@ -152,6 +152,9 @@ | |||
| # known-good version of OpenSSL, compile it, and link it to Cargo. | |||
| #openssl-static = false | |||
|
|
|||
| # Disable the vendoring of libs when creating dist archives | |||
| # disable-cargo-vendor = false | |||
There was a problem hiding this comment.
I think this may not be the intent we wish to convey, perhaps "disable building the source tarball" ?
There was a problem hiding this comment.
Was not sure how to call that.
Will update the comment, should I change the configuration key name too?
|
@alexcrichton Is a refactor of this kind what you had in mind? @aidanhs that error should be fixed now |
|
Looks great @Keruspe, thanks! For the
|
|
I'll try something like that. |
|
Yeah I'm ok with that too! |
…enabled Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Introduce a new Installer object that hold a reference to all the configured paths for installation Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
|
Dropped the commit and rebased on top of master |
|
@bors: r+ Thanks! |
|
📌 Commit 801e2b7 has been approved by |
rustbuild: install improvements Install rust-analysis and rust-src to get in par with what we can get from rustup. Allow bypassing the vendoring of dependencies. When we only build to install and not to redistribute dist tarballs, that part is not necessary, so avoid trying to install cargo-vendor.
rustbuild: install improvements Install rust-analysis and rust-src to get in par with what we can get from rustup. Allow bypassing the vendoring of dependencies. When we only build to install and not to redistribute dist tarballs, that part is not necessary, so avoid trying to install cargo-vendor.
|
⌛ Testing commit 801e2b7 with merge a3ec3c9... |
|
💔 Test failed - status-appveyor |
rustbuild: install improvements Install rust-analysis and rust-src to get in par with what we can get from rustup. Allow bypassing the vendoring of dependencies. When we only build to install and not to redistribute dist tarballs, that part is not necessary, so avoid trying to install cargo-vendor.
Install rust-analysis and rust-src to get in par with what we can get from rustup.
Allow bypassing the vendoring of dependencies. When we only build to install and not to redistribute dist tarballs, that part is not necessary, so avoid trying to install cargo-vendor.