Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactivate clippy in toolstate.toml #45411

Merged
merged 1 commit into from
Oct 21, 2017
Merged

Reactivate clippy in toolstate.toml #45411

merged 1 commit into from
Oct 21, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Oct 20, 2017

The Cargo.lock changes are b/c clippy is not its own workspace anymore, but is part of the main workspace

r? @Manishearth

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2017
@Mark-Simulacrum
Copy link
Member

cc @alexcrichton - does this look good to you?

@alexcrichton
Copy link
Member

Looks good!

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2017

📌 Commit 2812865 has been approved by Manishearth

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2017
@frewsxcv
Copy link
Member

@bors rollup

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Oct 21, 2017
@frewsxcv
Rollup merge of rust-lang#45411 - oli-obk:clippy, r=Manishearth
c96db06 
Reactivate clippy in toolstate.toml

The `Cargo.lock` changes are b/c clippy is not its own workspace anymore, but is part of the main workspace

r? @Manishearth
@frewsxcv frewsxcv mentioned this pull request Oct 21, 2017
Merged
bors added a commit that referenced this pull request Oct 21, 2017
@bors
Auto merge of #45430 - frewsxcv:rollup, r=frewsxcv
7e70546 
Rollup of 6 pull requests

- Successful merges: #45227, #45356, #45407, #45411, #45418, #45419
- Failed merges: #45421
@bors bors merged commit 2812865 into rust-lang:master Oct 21, 2017
@oli-obk oli-obk deleted the clippy branch October 23, 2017 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@oli-obk @Mark-Simulacrum @alexcrichton @Manishearth @bors @frewsxcv @kennytm