Fix most rendering warnings from switching to CommonMark #45419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alexcrichton who noticed this |
|
Other bug is #45420 |
|
r=me pending travis. apparently the footnote issue was fixed in a later version of pulldown, so it's just a matter of updating rustdoc to point at a version that contains that fix. I opened #45421 to do that. |
kennytm
added
the
S-waiting-on-review
|
📌 Commit f8f9005 has been approved by |
| @@ -22,7 +22,7 @@ use mem; | |||
| /// This is currently the default hashing function used by standard library | |||
| /// (eg. `collections::HashMap` uses it by default). | |||
| /// | |||
| /// See: https://131002.net/siphash/ | |||
| /// See: <https://131002.net/siphash> | |||
There was a problem hiding this comment.
Nitpick: inconsistent trailing slash.
There was a problem hiding this comment.
The version without the trailing slash results in a 301 redirect.
kennytm
added
S-waiting-on-bors
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Oct 21, 2017
…ngs, r=QuietMisdreavus Fix most rendering warnings from switching to CommonMark There's one big one lift, I'm filing a bug for it soon. r? @rust-lang/docs
bors
added a commit
that referenced
this pull request
Oct 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's one big one lift, I'm filing a bug for it soon.
r? @rust-lang/docs