stdlib support for Apple WatchOS #98101

vladimir-ea · 2022-06-14T17:08:58Z

This is a follow-up to #95243 (Add Apple WatchOS compiler targets) that adds stdlib support for Apple WatchOS.

rust-highfive · 2022-06-14T17:09:01Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-06-14T17:09:02Z

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

src/bootstrap/lib.rs

bors · 2022-06-15T17:42:05Z

☔ The latest upstream changes (presumably #95897) made this pull request unmergeable. Please resolve the merge conflicts.

thomcc · 2022-06-17T01:39:03Z

This owns, thanks for the PR.

After asking on Zulip, it seems like we probably want T-libs-api to sign off on stuff like MetadataExt, even though it's a copy of the trait for existing platforms. Also, in all likelihood, we don't want stuff like the raw module.

@rustbot label +T-libs-api -T-libs

vladimir-ea · 2022-06-30T11:21:11Z

This owns, thanks for the PR.

After asking on Zulip, it seems like we probably want T-libs-api to sign off on stuff like MetadataExt, even though it's a copy of the trait for existing platforms. Also, in all likelihood, we don't want stuff like the raw module.

@rustbot label +T-libs-api -T-libs

Hi - do I need to do anything to move this PR forward? @thomcc @Urgau

thomcc · 2022-06-30T16:27:02Z

I've nominated it to be discussed in the next libs meeting (next week), since the next steps are unclear. I probably should have done this earlier.

thomcc · 2022-07-07T12:33:36Z

Hey, the outcome of the libs meeting is we'd like you to move the parts that add new APIs into a separate PR. If you do that, there are no blockers.

That is, even though these are duplicates of APIs which exist already on other targets (e.g. ios), there are still multiple options for how to go about this -- as one example, it may be better to do something like re-export std::os::ios::MetadataExt rather than copy-pasting the declaration; or perhaps that would be worse. Either way, the details about this kind of thing can get hashed out separately from landing initial support for the platform, which is otherwise uncontroversial.

Thanks for the patience.

thomcc · 2022-07-07T12:34:34Z

I'll do a full review after those changes are made.

@rustbot label +S-waiting-on-author -S-waiting-on-review

vladimir-ea · 2022-07-07T12:41:05Z

Hey, the outcome of the libs meeting is we'd like you to move the parts that add new APIs into a separate PR. If you do that, there are no blockers.

Thanks - what parts are considered new apis?

rustbot · 2022-07-20T07:29:31Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

thomcc · 2022-07-20T07:31:02Z

Sorry, I missed this comment. You seem to have gotten it though.

thomcc · 2022-07-20T07:32:05Z

library/std/src/os/mod.rs

 #[cfg(target_os = "solid_asp3")]
 pub mod solid;
 #[cfg(target_os = "vxworks")]
 pub mod vxworks;
+#[cfg(target_os = "watchos")]
+pub mod ios;


Ah, can you hold off on this until another PR? Is this required to compile?

I think it is required - what is the issue?

It needs libs-api decision, I think -- the outcome of the libs meeting was just to pull this part out into another PR and land it separately if possible, so that more deliberation can happen.

I definitely don't think it should be called ios, and there are a lot of reasons the two might diverge (they're not even quite the same architecture, for example).

Anyway, please submit a separate PR with this part (or what you had before) and we can land the rest of this, and work out what to do with the std::os bit.

ok removed those parts

Thanks. I'll take another look tomorrow (it's 1am and I should double check), but I think it's probably fine to land with that.

vladimir-ea · 2022-07-20T07:32:50Z

Sorry, I missed this comment. You seem to have gotten it though.

Yes, apologies for the delay. I have changed library/std/src/os/mod.rs so that watchos includes the ios files rather than duplicating them (as suggested). This is fine I think, since watchOS is a cut down version of iOS and seems unlikely to diverge in these fundamentals.

vladimir-ea · 2022-07-20T08:16:08Z

The new api parts have been split off into a separate PR here: #99497

thomcc · 2022-07-20T09:05:09Z

Okay, did another pass on it tonight since I couldn't sleep, and this looks fine. New APIs are split out, perhaps with the exception of std::env::os, which I think is fine, since lacking that would make this OS unique, so I'm treating it as exposing an existing API on the target, which is... really what everything else in this PR is doing. Anyway, everything else seems to match (hopefully I didn't miss anything, but I've double checked at this point).

@bors r+

bors · 2022-07-20T09:05:11Z

📌 Commit 439d64a has been approved by thomcc

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - rust-lang#98101 (stdlib support for Apple WatchOS) - rust-lang#99345 (Do not allow typeck children items to constrain outer RPITs) - rust-lang#99383 (Formalize defining_use_anchor) - rust-lang#99436 (Add flag to configure `noalias` on `Box<T>`) - rust-lang#99483 (Fix a numerical underflow in tuple wrap suggestion) - rust-lang#99485 (Stop injecting `#[allow(unused_qualifications)]` in generated `derive` implementations) - rust-lang#99486 (Refactor: remove a string comparison between types in `check_str_addition`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…thomcc Standard library OS support for Apple WatchOS This PR was split from rust-lang#98101

Standard library OS support for Apple WatchOS This PR was split from rust-lang/rust#98101

Support Apple tvOS in libstd This target has existed in the compiler for a while, was `no_std`-only previously (even requiring `#![feature(restricted_std)]`). Apple tvOS is essentially the same as iOS, down to using the same version numbering, so there's no reason for this to be a `no_std`-only target the way it is currently. Not yet tested much (I have an Apple TV, but haven't tested that this can deploy and run programs on it, nor the simulator). Uses the implementation strategy as the watchOS support in rust-lang#98101 and etc. That is, no `std::os::` interfaces aside from those in `std::os::unix`. Includes an update to libc in order to pull in rust-lang/libc#2958.

Standard library OS support for Apple WatchOS This PR was split from rust-lang/rust#98101

rust-highfive assigned thomcc Jun 14, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 14, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2022

This comment has been minimized.

Sign in to view

vladimir-ea force-pushed the stdlib_watch_os branch from 8fe299f to cd52721 Compare June 14, 2022 17:24

Urgau reviewed Jun 14, 2022

View reviewed changes

src/bootstrap/lib.rs Outdated Show resolved Hide resolved

vladimir-ea force-pushed the stdlib_watch_os branch from cd52721 to b088673 Compare June 14, 2022 17:58

vladimir-ea force-pushed the stdlib_watch_os branch from b088673 to 19630be Compare June 15, 2022 19:16

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 17, 2022

thomcc added the I-libs-nominated Nominated for discussion during a libs team meeting. label Jun 30, 2022

vladimir-ea changed the title ~~Library changes for Apple WatchOS~~ stdlib support for Apple WatchOS Jul 6, 2022

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2022

vladimir-ea force-pushed the stdlib_watch_os branch from 19630be to 761fc3b Compare July 20, 2022 07:29

thomcc reviewed Jul 20, 2022

View reviewed changes

vladimir-ea force-pushed the stdlib_watch_os branch from 761fc3b to eda4cbb Compare July 20, 2022 07:44

Library changes for Apple WatchOS

439d64a

vladimir-ea force-pushed the stdlib_watch_os branch from eda4cbb to 439d64a Compare July 20, 2022 07:57

vladimir-ea mentioned this pull request Jul 20, 2022

Standard library OS support for Apple WatchOS #99497

Merged

vladimir-ea mentioned this pull request Jul 20, 2022

Implementation of raw_ext, metadata_ext and metadata_ext2 features for Apple WatchOS rust-lang/libs-team#75

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 20, 2022

Dylan-DPC mentioned this pull request Jul 20, 2022

Rollup of 7 pull requests #99506

Merged

m-ou-se removed the I-libs-nominated Nominated for discussion during a libs team meeting. label Jul 20, 2022

bors merged commit 90c59e7 into rust-lang:master Jul 20, 2022

rustbot added this to the 1.64.0 milestone Jul 20, 2022

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 6, 2022

Auto merge of rust-lang#99497 - vladimir-ea:stdlib_os_api_watchos, r=…

2d46584

…thomcc Standard library OS support for Apple WatchOS This PR was split from rust-lang#98101

RalfJung pushed a commit to RalfJung/miri that referenced this pull request Oct 7, 2022

Auto merge of #99497 - vladimir-ea:stdlib_os_api_watchos, r=thomcc

9125d0d

Standard library OS support for Apple WatchOS This PR was split from rust-lang/rust#98101

This was referenced Oct 24, 2022

Support Apple tvOS in libstd #103503

Merged

Add tvOS and watchOS support, identical to iOS support rust-random/getrandom#317

Merged

thomcc added the O-watchos Operating System: watchOS label Oct 25, 2022

thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Feb 10, 2023

Auto merge of #99497 - vladimir-ea:stdlib_os_api_watchos, r=thomcc

9155985

Standard library OS support for Apple WatchOS This PR was split from rust-lang/rust#98101

RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 20, 2024

Auto merge of #99497 - vladimir-ea:stdlib_os_api_watchos, r=thomcc

aac20e3

Standard library OS support for Apple WatchOS This PR was split from rust-lang/rust#98101

RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024

Auto merge of #99497 - vladimir-ea:stdlib_os_api_watchos, r=thomcc

3aa777f

Standard library OS support for Apple WatchOS This PR was split from rust-lang/rust#98101

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stdlib support for Apple WatchOS #98101

stdlib support for Apple WatchOS #98101

vladimir-ea commented Jun 14, 2022 •

edited

Loading

rust-highfive commented Jun 14, 2022

rust-highfive commented Jun 14, 2022

This comment has been minimized.

bors commented Jun 15, 2022

thomcc commented Jun 17, 2022

vladimir-ea commented Jun 30, 2022

thomcc commented Jun 30, 2022

thomcc commented Jul 7, 2022

thomcc commented Jul 7, 2022

vladimir-ea commented Jul 7, 2022

rustbot commented Jul 20, 2022

thomcc commented Jul 20, 2022

thomcc Jul 20, 2022

vladimir-ea Jul 20, 2022

thomcc Jul 20, 2022

vladimir-ea Jul 20, 2022

thomcc Jul 20, 2022

vladimir-ea commented Jul 20, 2022

vladimir-ea commented Jul 20, 2022

thomcc commented Jul 20, 2022

bors commented Jul 20, 2022

stdlib support for Apple WatchOS #98101

stdlib support for Apple WatchOS #98101

Conversation

vladimir-ea commented Jun 14, 2022 • edited Loading

rust-highfive commented Jun 14, 2022

rust-highfive commented Jun 14, 2022

This comment has been minimized.

bors commented Jun 15, 2022

thomcc commented Jun 17, 2022

vladimir-ea commented Jun 30, 2022

thomcc commented Jun 30, 2022

thomcc commented Jul 7, 2022

thomcc commented Jul 7, 2022

vladimir-ea commented Jul 7, 2022

rustbot commented Jul 20, 2022

thomcc commented Jul 20, 2022

thomcc Jul 20, 2022

Choose a reason for hiding this comment

vladimir-ea Jul 20, 2022

Choose a reason for hiding this comment

thomcc Jul 20, 2022

Choose a reason for hiding this comment

vladimir-ea Jul 20, 2022

Choose a reason for hiding this comment

thomcc Jul 20, 2022

Choose a reason for hiding this comment

vladimir-ea commented Jul 20, 2022

vladimir-ea commented Jul 20, 2022

thomcc commented Jul 20, 2022

bors commented Jul 20, 2022

vladimir-ea commented Jun 14, 2022 •

edited

Loading