Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard library OS support for Apple WatchOS #99497

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Standard library OS support for Apple WatchOS #99497

merged 1 commit into from
Oct 6, 2022

Conversation

vladimir-ea
Copy link
Contributor

This PR was split from #98101

@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 20, 2022
@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2022
@vladimir-ea vladimir-ea mentioned this pull request Jul 20, 2022
Merged
@vladimir-ea
Copy link
Contributor Author

@thomcc
@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 20, 2022
@thomcc
Copy link
Member

thomcc commented Jul 20, 2022 •
edited
Loading

Thank you. Can you make an API change proposal for this? See the bot's comment for links.

Also, I think kennytm is busy, so I'll take this once that's settled since I'm fairly familiar with the platform.

r? @thomcc

@rust-highfive rust-highfive assigned thomcc and unassigned kennytm Jul 20, 2022
@vladimir-ea
Copy link
Contributor Author

Thank you. Can you make an API change proposal for this? See the bot's comment for links.

Also, I think kennytm is busy, so I'll take this once that's settled since I'm fairly familiar with the platform.

r? @thomcc

Here is the issue: rust-lang/libs-team#75

@thomcc
Copy link
Member

thomcc commented Jul 20, 2022 •
edited
Loading

Thank you. Sorry for the back and forth.

@thomcc thomcc added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2022
@deg4uss3r
Copy link
Contributor

Hello everyone!

I noticed this work is a little stalled, anything I can do to help here?

@thomcc thomcc added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 14, 2022
@thomcc
Copy link
Member

thomcc commented Sep 14, 2022

Thanks for the reminder, I had meant to follow-up here. This needs API team decision, so I've marked it as nominated, and given a brief writeup here rust-lang/libs-team#75 (comment). It will be discussed next week in the API team meeting.

@thomcc
Copy link
Member

thomcc commented Sep 20, 2022

So, we discussed this in the most recent libs-api meeting. The outcome is that we'd like to only export these via std::os::unix, rather than having a watchos-specific public module. Could you make that change?

@m-ou-se m-ou-se removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 27, 2022
@deg4uss3r
Copy link
Contributor

@vladimir-ea are you around to make this change?

@vladimir-ea
Copy link
Contributor Author

So, we discussed this in the most recent libs-api meeting. The outcome is that we'd like to only export these via std::os::unix, rather than having a watchos-specific public module. Could you make that change?

Pushed the change (pub mod watchos -> pub(crate) mod watchos in library/std/src/os/mod.rs).

Thank you @thomcc for taking the time to discuss this / make it right.

@vladimir-ea
Copy link
Contributor Author

@vladimir-ea are you around to make this change?

Yes, sorry for the delay.

@vladimir-ea
Copy link
Contributor Author

@rustbot label +S-waiting-on-review

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2022
@thomcc thomcc removed the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label Oct 2, 2022
@thomcc
Copy link
Member

thomcc commented Oct 6, 2022

Thanks! Glad to see it, everything looks fine.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 6, 2022

📌 Commit 2edbcf7 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2022
@bors
Copy link
Contributor

bors commented Oct 6, 2022

⌛ Testing commit 2edbcf7 with merge 2d46584...

@bors
Copy link
Contributor

bors commented Oct 6, 2022

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 2d46584 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 6, 2022
@bors bors merged commit 2d46584 into rust-lang:master Oct 6, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 6, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2d46584): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.3% [1.3%, 1.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@vladimir-ea vladimir-ea mentioned this pull request Oct 13, 2022
Closed
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#99497 - vladimir-ea:stdlib_os_api_watchos, r=…
9125d0d 
…thomcc

Standard library OS support for Apple WatchOS

This PR was split from rust-lang#98101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
9 participants
@vladimir-ea @rustbot @rust-highfive @thomcc @deg4uss3r @bors @rust-timer @kennytm @m-ou-se