feat(rdb): print messages while exporting backup #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mia-Cross
added
rdb
Mia-Cross
force-pushed
the
rdb_autoexport_backup
branch
from
3776ba8
to
c7e7950
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3479 +/- ##
==========================================
- Coverage 75.67% 75.66% -0.01%
==========================================
Files 175 175
Lines 39087 39098 +11
==========================================
+ Hits 29579 29584 +5
- Misses 8433 8437 +4
- Partials 1075 1077 +2
☔ View full report in Codecov by Sentry. |
remyleone
reviewed
Nov 9, 2023
internal/namespaces/rdb/v1/testdata/test-create-backup-simple.golden
Outdated
Show resolved
Hide resolved
Mia-Cross
force-pushed
the
rdb_autoexport_backup
branch
2 times, most recently
from
411ca20
to
554d60c
Compare
Mia-Cross
force-pushed
the
rdb_autoexport_backup
branch
from
1a973de
to
b3cf0d6
Compare
remyleone
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1434
The feature was already implemented by @yfodil, this PR just adds a message to inform the user that the backup is being exported.