Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(rdb): fix tests + update cassettes and goldens #3480

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

Mia-Cross
Copy link
Contributor

A few tests needed to be updates to stay consistent with the latest validation rules for backups and settings order.

Should be merged before #3473 and #3479

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.65%. Comparing base (20deb6c) to head (49b2c57).
Report is 451 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3480   +/-   ##
=======================================
  Coverage   75.65%   75.65%           
=======================================
  Files         175      175           
  Lines       39035    39035           
=======================================
  Hits        29533    29533           
  Misses       8429     8429           
  Partials     1073     1073           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Nov 9, 2023
Merged via the queue into scaleway:master with commit 88fa35b Nov 9, 2023
12 checks passed
@Mia-Cross Mia-Cross deleted the rdb_fix_tests branch November 9, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants