kcfinder: fix a silent blank page on critial errors #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if there is a critical error during early object construction the script just dies silently. This patch fixes it making sure that the error message would be passed down and e.g. displayed in a message box. See also * upstream PR: sunhater/kcfinder#177 * original issue repot [russian]: https://mjdm.ru/forum/viewtopic.php?f=24&t=6177
|
Please re-submit the fix to the alpha-branch. Thank you. |
|
Done. @sergejey, I'm wondering, will it be (in the case if it will be accepted) cherry-picked/merged into master as well soon enough (e.g. sooner than several months)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if there is a critical error during early object construction
the script just dies silently. This patch fixes it making sure that the
error message would be passed down and e.g. displayed in a message box.
See also
https://mjdm.ru/forum/viewtopic.php?f=24&t=6177