Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Fix a silent blank page on critial errors #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fat-Zer
Copy link

@Fat-Zer Fat-Zer commented Feb 28, 2019

Currently if there is a critical error during early object construction
the script just dies silently. This patch fixes it making sure that the error
message would be passed down and e.g. displayed in a message box.
One example of such error is:

Cannot find any of the supported PHP image extensions!

Currently if there is a critical error during early object construction
the script just dies silently. This patch fixes it making sure that the error
message would be passed down and e.g. displayed in a message box.
One example of such error is:

> Cannot find any of the supported PHP image extensions!
@Fat-Zer Fat-Zer mentioned this pull request Feb 28, 2019
Fat-Zer added a commit to Fat-Zer/majordomo that referenced this pull request Feb 28, 2019
Currently if there is a critical error during early object construction
the script just dies silently. This patch fixes it making sure that the
error message would be passed down and e.g. displayed in a message box.

See also
 * upstream PR: sunhater/kcfinder#177
 * original issue repot [russian]:
   https://mjdm.ru/forum/viewtopic.php?f=24&t=6177
Fat-Zer added a commit to Fat-Zer/majordomo that referenced this pull request Feb 28, 2019
Currently if there is a critical error during early object construction
the script just dies silently. This patch fixes it making sure that the
error message would be passed down and e.g. displayed in a message box.

See also
 * upstream PR: sunhater/kcfinder#177
 * original issue repot [russian]:
   https://mjdm.ru/forum/viewtopic.php?f=24&t=6177
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant