Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types for the useCallback hook #302

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Fix types for the useCallback hook #302

merged 1 commit into from
Jan 30, 2020

Conversation

ramnivas
Copy link
Contributor

@ramnivas ramnivas commented Jan 2, 2020

No description provided.

@shadaj shadaj force-pushed the master branch 8 times, most recently from 29fe37b to 4d7136c Compare January 22, 2020 03:36
@ramnivas
Fix types for the useCallback hook
3497169 
Implement useCallback using useMemo. Since the purpose of `useCallback`
is to guarantee _refererence_ equality, the use of React's useCallback
as the underlying implementation will require a conversion back from
`js.Function` to `scala.FunctionN` and that will create a new object
every time and thus not serve the intended purpose.
shadaj
shadaj approved these changes Jan 30, 2020
View reviewed changes
Copy link
Owner

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadaj shadaj merged commit c6518db into shadaj:master Jan 30, 2020
@shadaj shadaj added this to the v0.6.4 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadaj shadaj shadaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ramnivas @shadaj