Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types for the useCallback hook #302

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Fix types for the useCallback hook #302

merged 1 commit into from
Jan 30, 2020

Commits on Jan 28, 2020

  1. Fix types for the useCallback hook 

    Implement useCallback using useMemo. Since the purpose of `useCallback`
is to guarantee _refererence_ equality, the use of React's useCallback
as the underlying implementation will require a conversion back from
`js.Function` to `scala.FunctionN` and that will create a new object
every time and thus not serve the intended purpose.
    @ramnivas
    ramnivas committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    3497169 View commit details
    Browse the repository at this point in the history