Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include contents of custom assets metadata.yaml in --diagnostics #2107

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

Enselic
Copy link
Collaborator

@Enselic Enselic commented Mar 3, 2022

Output without custom assets:

Custom assets metadata

Could not read contents of '/Users/martin/.cache/bat/metadata.yaml': No such file or directory (os error 2).

Output with custom assets:

Custom assets metadata

---
bat_version: 0.20.0
creation_time:
  secs_since_epoch: 1646283165
  nanos_since_epoch: 208676000

Remark

When we have access to sharkdp/bugreport#11 we will be able to get even more info for custom assets, but the metadata is a significant giver of valuable information by itself that we can add already now to bat, so let's do that.

This will help slightly with #2085

@Enselic Enselic changed the title bin: Add custom assets metadata.yaml to --diagnostics Include contents of custom assets metadata.yaml in --diagnostics Mar 3, 2022
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Enselic Enselic merged commit 9ab378b into sharkdp:master Mar 7, 2022
@Enselic Enselic deleted the metadata-diagnostics branch March 7, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants