-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New collector DirectoryEntries
#11
Conversation
c3dcf27
to
cb138df
Compare
It would also be valuable to use Btw, seems like CI has hanged, but that seems to be fixed by #12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. This looks great!
We'll do this some other time.
Thank you. Let me know when/if I should release a new version in order to integrate this into |
@sharkdp If you could make a release of bugreport when you get time that would be great. (I wanted to wait a bit to see if I could think of something else to do before a release but nothing has come to mind.) |
Yes, of course: https://crates.io/crates/bugreport/0.5.0 |
The use case I have in mind is to add info about custom assets to bat. If we add this line to bat:
we will get output in
--diagnostics
that look like this if custom assets are installed:and like this
or this
if no custom assets are installed.
I took some liberties in the structure and interface of the new collector.
new_with_title_from_local_variable()
example in tests. That code does not work for e.g.FileContents
.I still made the new collector appear in the right place in the module hierarchy though, as can be demonstrated with
cargo public-items
:or just a quick look at the
cargo doc
HTML if you're old-school :)This is pretty bare-bones in terms of functionality (see docs in the code for limitations and idea for future improvements) but it should suit the bat use case well.