Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] source ~/.bashrc when tailing managed jobs logs #3536

Merged
merged 1 commit into from
May 10, 2024
Merged

[Core] source ~/.bashrc when tailing managed jobs logs #3536

merged 1 commit into from
May 10, 2024

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented May 10, 2024 •
edited
Loading

Fixes #3531

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Michaelvll
Michaelvll approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @cblmemo ! Thanks for the fix.

@cblmemo cblmemo merged commit fa3302e into master May 10, 2024
20 checks passed
@cblmemo cblmemo deleted the fix-k8s-logs branch May 10, 2024 14:24
@Michaelvll
Copy link
Collaborator

Michaelvll commented May 10, 2024 •
edited
Loading

Do we need to source bashrc for the service as well? Also, should only source bashrc when the cluster is on k8s?

@cblmemo
Copy link
Collaborator Author

cblmemo commented May 10, 2024

Do we need to source bashrc for the service as well? Also, should only source bashrc when the cluster is on k8s?

Good point! Lemme test and fix it if it is problematic.

@cblmemo
Copy link
Collaborator Author

cblmemo commented May 10, 2024

Do we need to source bashrc for the service as well? Also, should only source bashrc when the cluster is on k8s?

Fixed in #3537

@Michaelvll Michaelvll mentioned this pull request May 21, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Jobs][k8s] Streaming logs fails for job controller
2 participants
@cblmemo @Michaelvll