Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] source ~/.bashrc when tailing SkyServe logs #3537

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented May 10, 2024

Similar to #3531, SkyServe logs experienced similar behaviour. This PR fixes it.

I 05-10 14:45:40 replica_managers.py:103] Replica cluster http-1 launched.
Start streaming logs for task job of replica 1...
I 05-10 14:46:00 cloud_vm_ray_backend.py:3660] Job ID not provided. Streaming the logs of the latest job.
kubectl port-forward failed. Error: E0510 14:46:00.754177    4721 memcache.go:265] couldn't get current server API group list: Get "http://localhost:8080/api?timeout=32s": dial tcp [::1]:8080: connect: connection refused
E0510 14:46:00.754784    4721 memcache.go:265] couldn't get current server API group list: Get "http://localhost:8080/api?timeout=32s": dial tcp [::1]:8080: connect: connection refused
E0510 14:46:00.756412    4721 memcache.go:265] couldn't get current server API group list: Get "http://localhost:8080/api?timeout=32s": dial tcp [::1]:8080: connect: connection refused
E0510 14:46:00.756954    4721 memcache.go:265] couldn't get current server API group list: Get "http://localhost:8080/api?timeout=32s": dial tcp [::1]:8080: connect: connection refused
The connection to the server localhost:8080 was refused - did you specify the right host or port?
kex_exchange_identification: Connection closed by remote host
Connection closed by UNKNOWN port 65535
kex_exchange_identification: Connection closed by remote host
Connection closed by UNKNOWN port 65535
Failed to stream logs for replica 1.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@cblmemo cblmemo merged commit e6cd19c into master May 10, 2024
20 checks passed
@cblmemo cblmemo deleted the fix-serve-logs branch May 10, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants