feat: add a function to verify and return Abilities. #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a list of strings representing capability names (Abilities), verify that all the strings are valid Abilities and return Abilities[]. Abilities[] is still just a list of strings, but this helps us play nice with Typescript. Inspired by #1250
alanshaw
reviewed
Jan 8, 2024
|
Thanks @alanshaw! I've reworked this a bit per your suggestions. |
alanshaw
approved these changes
Jan 11, 2024
|
Sure! And yea, the overlap with Ucanto is the issue - we export them all from the access client so calling it FWIW I was thinking of it as the repo/package name rather than the product name, but I don't have strong feelings - will call it |
Per PR conversation
This was referenced Jan 11, 2024
travis
pushed a commit
that referenced
this pull request
Jan 17, 2024
🤖 I have created a release *beep* *boop* --- ## [12.1.0](w3up-client-v12.0.0...w3up-client-v12.1.0) (2024-01-17) ### Features * add a function to verify and return Abilities. ([#1252](#1252)) ([2f026a2](2f026a2)) * re-export Store implementations from w3up-client ([#1266](#1266)) ([b3c6b46](b3c6b46)) * strictly require nodejs version ([#1264](#1264)) ([bc9f427](bc9f427)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
travis
pushed a commit
that referenced
this pull request
Jan 25, 2024
🤖 I have created a release *beep* *boop* --- ## [13.1.0](capabilities-v13.0.0...capabilities-v13.1.0) (2024-01-25) ### Features * add `initialize` method to `PlansStorage` ([#1278](#1278)) ([6792126](6792126)) * add a function to verify and return Abilities. ([#1252](#1252)) ([2f026a2](2f026a2)) * change `plan/update` to `plan/set` and use existing `PlansStorage#set` to implement an invocation handler ([#1258](#1258)) ([1ccbfe9](1ccbfe9)) * introduce capability for changing billing plan ([#1253](#1253)) ([d33b3a9](d33b3a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a list of strings representing capability names (
W3UpAbilitys), verify that all the strings are validW3UpAbilitys and returnW3UpAbility[].W3UpAbility[]is still just a list of strings, but this helps us play nice with Typescript.Inspired by #1250