feat: re-export Store implementations from w3up-client #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful to be able to use these in code that doesn't want a dependency on `access-client`.
travis
added a commit
to storacha/www
that referenced
this pull request
Jan 17, 2024
1) Add missing `importDAG` and `CarReader` imports 2) Use `StoreMemory` in example to avoid annoying `Error: store cannot be used with did:key:z6xyz, stored principal and passed principal must match` error. I started out trying to do (1) but bumped into the error in (2) after running the test code once. Customers have run into this before and we usually tell them to use `StoreMemory` - I think that's the right thing in this case anyway so this feels like a win! I'd like to update this one more time once storacha/w3up#1266 is released so we can get rid of the dependency on `@web3-storage/access`. Fixes #63
alanshaw
reviewed
Jan 17, 2024
|
I definitely do 😅 thx! |
alanshaw
approved these changes
Jan 17, 2024
travis
pushed a commit
that referenced
this pull request
Jan 17, 2024
🤖 I have created a release *beep* *boop* --- ## [12.1.0](w3up-client-v12.0.0...w3up-client-v12.1.0) (2024-01-17) ### Features * add a function to verify and return Abilities. ([#1252](#1252)) ([2f026a2](2f026a2)) * re-export Store implementations from w3up-client ([#1266](#1266)) ([b3c6b46](b3c6b46)) * strictly require nodejs version ([#1264](#1264)) ([bc9f427](bc9f427)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
travis
added a commit
to storacha/www
that referenced
this pull request
Jan 17, 2024
1) Add missing `importDAG` and `CarReader` imports 2) Use `StoreMemory` in example to avoid annoying `Error: store cannot be used with did:key:z6xyz, stored principal and passed principal must match` error. I started out trying to do (1) but bumped into the error in (2) after running the test code once. Customers have run into this before and we usually tell them to use `StoreMemory` - I think that's the right thing in this case anyway so this feels like a win! I'd like to update this one more time once storacha/w3up#1266 is released so we can get rid of the dependency on `@web3-storage/access`. Fixes #63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to be able to use these in code that doesn't want a dependency on
access-client.