feat: block slides insert before image load finished (#7948)

toeverything · Aug 22, 2024 · b57388f · b57388f
1 parent 5e555b3
commit b57388f
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 100 deletions.
diff --git a/packages/frontend/core/src/blocksuite/presets/ai/actions/edgeless-response.ts b/packages/frontend/core/src/blocksuite/presets/ai/actions/edgeless-response.ts
@@ -18,11 +18,13 @@ import {
   fitContent,
   ImageBlockModel,
   InsertBelowIcon,
+  LightLoadingIcon,
   NoteDisplayMode,
   ResetIcon,
 } from '@blocksuite/blocks';
 import { assertExists, Bound } from '@blocksuite/global/utils';
-import type { TemplateResult } from 'lit';
+import { html, type TemplateResult } from 'lit';
+import { styleMap } from 'lit/directives/style-map.js';
 
 import { AIPenIcon, ChatWithAIIcon } from '../_common/icons';
 import { insertFromMarkdown } from '../_common/markdown-utils';
@@ -98,27 +100,55 @@ export function retry(panel: AffineAIPanelWidget): AIItemConfig {
   };
 }
 
+const extraConditions: Record<string, (data: any) => boolean> = {
+  createSlides: data => !!data.contents,
+};
 export function createInsertResp<T extends keyof BlockSuitePresets.AIActions>(
   id: T,
   handler: (host: EditorHost, ctx: CtxRecord) => void,
   host: EditorHost,
   ctx: CtxRecord,
   buttonText: string = 'Insert below'
-): AIItemConfig {
-  return {
-    name: buttonText,
-    icon: InsertBelowIcon,
-    showWhen: () => {
-      const panel = getAIPanel(host);
-      return !EXCLUDING_INSERT_ACTIONS.includes(id) && !!panel.answer;
+): AIItemConfig[] {
+  const extraCondition = extraConditions[id] || ((_: any) => true);
+  return [
+    {
+      name: `${buttonText} - Loading...`,
+      icon: html`<div style=${styleMap({ height: '20px', width: '20px' })}>
+        ${LightLoadingIcon}
+      </div>`,
+      showWhen: () => {
+        const panel = getAIPanel(host);
+        const data = ctx.get();
+        return (
+          !EXCLUDING_INSERT_ACTIONS.includes(id) &&
+          !!panel.answer &&
+          // required data for insert
+          !extraCondition(data)
+        );
+      },
     },
-    handler: () => {
-      reportResponse('result:insert');
-      handler(host, ctx);
-      const panel = getAIPanel(host);
-      panel.hide();
+    {
+      name: buttonText,
+      icon: InsertBelowIcon,
+      showWhen: () => {
+        const panel = getAIPanel(host);
+        const data = ctx.get();
+        return (
+          !EXCLUDING_INSERT_ACTIONS.includes(id) &&
+          !!panel.answer &&
+          // required data for insert
+          !!extraCondition(data)
+        );
+      },
+      handler: () => {
+        reportResponse('result:insert');
+        handler(host, ctx);
+        const panel = getAIPanel(host);
+        panel.hide();
+      },
     },
-  };
+  ];
 }
 
 export function asCaption<T extends keyof BlockSuitePresets.AIActions>(
@@ -555,7 +585,7 @@ export function actionToResponse<T extends keyof BlockSuitePresets.AIActions>(
               panel.hide();
             },
           },
-          getInsertAndReplaceHandler(id, host, ctx, variants),
+          ...getInsertAndReplaceHandler(id, host, ctx, variants),
           asCaption(id, host),
           retry(getAIPanel(host)),
           discard(getAIPanel(host), getEdgelessCopilotWidget(host)),
@@ -603,7 +633,7 @@ export function actionToErrorResponse<
     responses: [
       {
         name: 'Response',
-        items: [getInsertAndReplaceHandler(id, host, ctx, variants)],
+        items: getInsertAndReplaceHandler(id, host, ctx, variants),
       },
       {
         name: '',

diff --git a/packages/frontend/core/src/blocksuite/presets/ai/chat-panel/utils.ts b/packages/frontend/core/src/blocksuite/presets/ai/chat-panel/utils.ts
diff --git a/packages/frontend/core/src/blocksuite/presets/ai/messages/slides-renderer.ts b/packages/frontend/core/src/blocksuite/presets/ai/messages/slides-renderer.ts
@@ -85,6 +85,10 @@ export class AISlidesRenderer extends WithDisposable(LitElement) {
               contents: res.contents,
               images: res.images,
             });
+            // refresh loading menu item
+            getAIPanel(this.host)
+              .shadowRoot?.querySelector('ai-panel-answer')
+              ?.requestUpdate();
           }
         })
         .catch(console.error);