Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: block slides insert before image load finished #7948

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

darkskygit
Copy link
Member

No description provided.

@graphite-app graphite-app bot requested review from CatsJuice, Brooooooklyn, JimmFly, EYHN and forehalo and removed request for CatsJuice August 22, 2024 10:30
Copy link

graphite-app bot commented Aug 22, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@graphite-app graphite-app bot requested a review from pengx17 August 22, 2024 10:30
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @darkskygit and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 22, 2024

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 55.22%. Comparing base (5e555b3) to head (b57388f).
Report is 1 commits behind head on canary.

Files Patch % Lines
...blocksuite/presets/ai/actions/edgeless-response.ts 6.25% 15 Missing ⚠️
.../blocksuite/presets/ai/messages/slides-renderer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7948      +/-   ##
==========================================
- Coverage   55.23%   55.22%   -0.02%     
==========================================
  Files        1054     1054              
  Lines       44670    44680      +10     
  Branches     5262     5263       +1     
==========================================
  Hits        24673    24673              
- Misses      19619    19629      +10     
  Partials      378      378              
Flag Coverage Δ
server-test 77.67% <ø> (ø)
unittest 26.96% <5.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

perfsee bot commented Aug 22, 2024

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                        EntryPoint: app                        @@
##                     canary …fix-ppt-await                 +/- ##
===================================================================
< Bundle              22.2 MB        22.2 MB      +286 B(+0.00%)   
< Initial JS          9.68 MB        9.68 MB      +286 B(+0.00%)   
= Initial CSS          184 kB         184 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   65             65                       
= Chunks                   63             63                       
= Packages                291            291                       
= Duplicates               23             23                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Improve page load speed with `preconnect` or `dns-prefetch`      
! Avoid cache wasting                                              

Copy link

graphite-app bot commented Aug 22, 2024

Merge activity

@graphite-app graphite-app bot merged commit b57388f into canary Aug 22, 2024
33 checks passed
@graphite-app graphite-app bot deleted the darksky/fix-ppt-await branch August 22, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants