Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): add server runtime config settings #7618

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Jul 26, 2024

close AF-1041

CleanShot.2024-07-26.at.21.10.19.mp4

Copy link

graphite-app bot commented Jul 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review July 26, 2024 13:04
Copy link

nx-cloud bot commented Jul 26, 2024

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.99%. Comparing base (7f7c051) to head (8174776).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7618   +/-   ##
=======================================
  Coverage   26.99%   26.99%           
=======================================
  Files         810      810           
  Lines       19554    19554           
  Branches     3636     3636           
=======================================
  Hits         5278     5278           
  Misses      13961    13961           
  Partials      315      315           
Flag Coverage Δ
unittest 26.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch 2 times, most recently from bfa59db to 76526c1 Compare July 26, 2024 14:29
@JimmFly JimmFly changed the base branch from jimmfly/0718/selfhost-setup to jimmfly/0718/admin-config July 26, 2024 14:29
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from 76526c1 to fe37ef8 Compare July 29, 2024 06:19
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from fe37ef8 to c8d4990 Compare July 29, 2024 15:07
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from c8d4990 to 910c196 Compare July 30, 2024 02:03
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from 910c196 to 325c4fc Compare July 30, 2024 03:38
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from 325c4fc to 12a8483 Compare July 30, 2024 03:47
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from 12a8483 to e234912 Compare July 30, 2024 06:08
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from e234912 to ffbcfa2 Compare July 31, 2024 04:15
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from ffbcfa2 to 8ed7655 Compare July 31, 2024 05:42
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from 8ed7655 to 62aa754 Compare August 1, 2024 06:21
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from 62aa754 to e6ba824 Compare August 5, 2024 10:31
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from e6ba824 to 6153c53 Compare August 6, 2024 08:47
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from 6153c53 to 9bbc8cd Compare August 8, 2024 07:11
@JimmFly JimmFly force-pushed the jimmfly/0718/selfhost-settings branch from 9bbc8cd to 4f40480 Compare August 12, 2024 08:22
Copy link

graphite-app bot commented Aug 13, 2024

Merge activity

@forehalo forehalo force-pushed the jimmfly/0718/selfhost-settings branch from 324cfee to 8174776 Compare August 13, 2024 06:40
@forehalo forehalo merged commit bf6e36d into canary Aug 13, 2024
33 checks passed
@forehalo forehalo deleted the jimmfly/0718/selfhost-settings branch August 13, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants