Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): handle error login status #7646

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Jul 30, 2024

Fix unhandled error login status, modify style

CleanShot.2024-07-30.at.12.44.49.mp4

Copy link

graphite-app bot commented Jul 30, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Jul 30, 2024

@JimmFly JimmFly changed the title fix(admin): unexpected navigate fix(admin): handle error login status Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.49%. Comparing base (b214003) to head (6dea831).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7646   +/-   ##
=======================================
  Coverage   55.49%   55.49%           
=======================================
  Files        1019     1019           
  Lines       43681    43681           
  Branches     5202     5202           
=======================================
  Hits        24240    24240           
  Misses      19073    19073           
  Partials      368      368           
Flag Coverage Δ
server-test 78.59% <ø> (ø)
unittest 26.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly marked this pull request as ready for review July 30, 2024 05:03
@JimmFly JimmFly force-pushed the jimmfly/0730/fix-setup-login branch from 34555ba to 4d5c008 Compare July 30, 2024 06:08
@JimmFly JimmFly force-pushed the jimmfly/0730/fix-setup-login branch 2 times, most recently from 92c1645 to c1a5225 Compare July 31, 2024 04:53
@JimmFly JimmFly force-pushed the jimmfly/0730/fix-setup-login branch from c1a5225 to 65b535a Compare July 31, 2024 05:42
@JimmFly JimmFly force-pushed the jimmfly/0730/fix-setup-login branch from 65b535a to 55fcf5b Compare August 1, 2024 06:21
@JimmFly JimmFly force-pushed the jimmfly/0730/fix-setup-login branch from 55fcf5b to 846e4b1 Compare August 5, 2024 10:31
@JimmFly JimmFly force-pushed the jimmfly/0730/fix-setup-login branch from 846e4b1 to 8b469ac Compare August 6, 2024 08:47
@JimmFly JimmFly force-pushed the jimmfly/0730/fix-setup-login branch 2 times, most recently from 6c29d0d to 701d6d3 Compare August 12, 2024 09:27
@forehalo forehalo changed the base branch from jimmfly/0718/selfhost-ai to canary August 12, 2024 13:21
@forehalo forehalo changed the base branch from canary to jimmfly/0718/selfhost-ai August 12, 2024 13:28
Copy link

graphite-app bot commented Aug 13, 2024

Merge activity

@forehalo forehalo force-pushed the jimmfly/0730/fix-setup-login branch from 8dfa4f8 to 6dea831 Compare August 13, 2024 06:52
Base automatically changed from jimmfly/0718/selfhost-ai to canary August 13, 2024 07:04
@graphite-app graphite-app bot merged commit 6dea831 into canary Aug 13, 2024
33 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0730/fix-setup-login branch August 13, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants