Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scan): do not dedup middleware handlers #880

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#18518

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • x ] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently we are deduplicating middleware, which means only one middleware will ever be included in the built app. We should probably only deduplicate routes that have a path.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jan 25, 2023
@danielroe danielroe requested a review from pi0 January 25, 2023 17:26
@danielroe danielroe self-assigned this Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #880 (8e66f14) into main (2c52c62) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
- Coverage   67.42%   67.35%   -0.08%     
==========================================
  Files          59       59              
  Lines        5852     5853       +1     
  Branches      633      632       -1     
==========================================
- Hits         3946     3942       -4     
- Misses       1897     1901       +4     
- Partials        9       10       +1     
Impacted Files Coverage Ξ”
src/scan.ts 72.72% <100.00%> (+0.25%) ⬆️
src/rollup/config.ts 91.66% <0.00%> (-0.93%) ⬇️
src/utils/index.ts 52.35% <0.00%> (-0.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix: include all middleware in handlers fix(scan): do not dedup middleware handlers Jan 25, 2023
@pi0
Copy link
Member

pi0 commented Jan 25, 2023

Thanks!

@pi0 pi0 merged commit 153f286 into main Jan 25, 2023
@pi0 pi0 deleted the fix/middleware-dedupe branch January 25, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants