Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude middlewares from being filtered out in scanned handlers #881

Closed
wants to merge 6 commits into from

Conversation

yassilah
Copy link
Contributor

πŸ”— Linked issue

Fixes nuxt/nuxt#18518 due to regression in #807.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@yassilah yassilah changed the title fix: exclude middlewares from being filtered out in scannedMiddlewares fix: exclude middlewares from being filtered out in scanned handlers Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #881 (c9f2b61) into main (2c52c62) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #881      +/-   ##
==========================================
- Coverage   67.42%   67.35%   -0.08%     
==========================================
  Files          59       59              
  Lines        5852     5853       +1     
  Branches      633      632       -1     
==========================================
- Hits         3946     3942       -4     
- Misses       1897     1901       +4     
- Partials        9       10       +1     
Impacted Files Coverage Ξ”
src/scan.ts 72.72% <100.00%> (+0.25%) ⬆️
src/rollup/config.ts 91.66% <0.00%> (-0.93%) ⬇️
src/utils/index.ts 52.35% <0.00%> (-0.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0
Copy link
Member

pi0 commented Jan 25, 2023

Thanks for PR dear @yassilah. Merged via #880

@pi0 pi0 closed this Jan 25, 2023
@yassilah yassilah deleted the filter-scan-dirs branch January 25, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.1] Many server middlewares issue
2 participants